Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct mocha flat example #236

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Oct 12, 2024

Issue

The text and example code in FLAT-CONFIG > Cypress and Mocha recommended disagree.

Whereas in the text it says:

The settings for individual mocha rules from the configs.flat.recommended option are changed.

the example sets the rule to warn which is the same as the setting from eslint-plugin-mocha's flat file recommended option configs.flat.recommended.

Change

Change the example rule setting to match the text. Use error throughout:

    rules: {
      'mocha/no-exclusive-tests': 'error',
      'mocha/no-skipped-tests': 'error',
    ...

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added the bug label Oct 12, 2024
@MikeMcC399 MikeMcC399 self-assigned this Oct 12, 2024
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 12, 2024 10:47
@jennifer-shehane jennifer-shehane merged commit 2097c42 into cypress-io:master Oct 16, 2024
8 checks passed
@MikeMcC399 MikeMcC399 deleted the fix/mocha-flat-example branch October 16, 2024 14:15
@cypress-app-bot
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants