Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.copy drops node.id. #61

Open
mbostock opened this issue Oct 27, 2016 · 2 comments
Open

node.copy drops node.id. #61

mbostock opened this issue Oct 27, 2016 · 2 comments

Comments

@mbostock
Copy link
Member

The node.id property is set by d3-stratify, but it isn’t an “official” part of the node interface, and so it’s not copied by node.copy. It’d be nice if it were.
@mbostock mbostock self-assigned this Oct 27, 2016
@mbostock mbostock added this to the 1.1 milestone Oct 27, 2016
@mbostock
Copy link
Member Author

Related #33, node.name.

@mbostock mbostock mentioned this issue Dec 11, 2017
Closed
@mbostock mbostock removed this from the 1.2 milestone Jan 29, 2019
@mbostock mbostock removed their assignment Nov 17, 2019
@mbostock
Copy link
Member Author

I’m not sure we want to make node.id part of the official API; we might want node.name instead. I think this should be reconsidered as part of the effort to make hierarchies immutable. #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbostock