Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Pipes tests arguments #75

Open
danielgafni opened this issue Dec 25, 2024 · 3 comments · May be fixed by #76
Open

Standardize Pipes tests arguments #75

danielgafni opened this issue Dec 25, 2024 · 3 comments · May be fixed by #76

Comments

@danielgafni
Copy link
Contributor

danielgafni commented Dec 25, 2024

Currently Pipes tests arguments are a bit messy.
I am planning to clean them up and possible add more structure to CLI arguments.

Proposals:

  1. Remove --env and --full flags. They don't really have any useful meaning.
  2. Remove --job-name argument from all tests except test_components.
  3. Remove test_context_reconstruction. It doesn't do anything which can't be part of test_components.
  4. Rename --custom-payload-path to --custom-payload to be consistent with other arguments
  5. Add a --test-name argument which will be set uniquely for each test. Remove obsolete flags like --throw-error, --logging (check if --test-name matches test_error_reporting and similar conditions instead).

This change will require at least 3 PRs:

  1. Changing the test suite
  2. Changing Rust code
  3. Changing Java code

What are your thoughts @GingerYouth @marijncv @wingyplus?

@wingyplus
Copy link
Contributor

Totally agreed. 🎉

@danielgafni danielgafni linked a pull request Dec 25, 2024 that will close this issue
@GingerYouth
Copy link
Collaborator

True. Will change Java core according to your proposal.

@marijncv
Copy link
Collaborator

Sounds good to me 👍 Created the rust PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants