From 05740a48239e4df9d3bbe4ed6d9375d7e77d975b Mon Sep 17 00:00:00 2001 From: jamiedemaria Date: Tue, 22 Oct 2024 14:04:35 -0400 Subject: [PATCH] fix partition set name for runs feed tests (#25408) ## Summary & Motivation updates the partition_set name in a test so that it conforms to the expected pattern https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster/_core/remote_representation/external_data.py#L1800 important for https://github.com/dagster-io/internal/pull/12131 since it relies on the job name of a backfill being stored correctly. it's not stored correctly if the test uses the wrong format ## How I Tested These Changes --- .../dagster_graphql_tests/graphql/test_runs_feed.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_runs_feed.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_runs_feed.py index 3c8cce3b18120..776dd3370f887 100644 --- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_runs_feed.py +++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_runs_feed.py @@ -3,6 +3,7 @@ import pytest from dagster._core.execution.backfill import BulkActionStatus, PartitionBackfill +from dagster._core.remote_representation.external_data import partition_set_snap_name_for_job_name from dagster._core.remote_representation.origin import RemotePartitionSetOrigin from dagster._core.storage.dagster_run import DagsterRun, DagsterRunStatus from dagster._core.storage.tags import BACKFILL_ID_TAG @@ -930,7 +931,7 @@ def test_get_runs_feed_filter_job_name(self, graphql_context): partition_set_origin = RemotePartitionSetOrigin( repository_origin=repository.get_remote_origin(), - partition_set_name="foo_partition", + partition_set_name=partition_set_snap_name_for_job_name("foo"), ) for _ in range(3): _create_run(graphql_context, job_name="foo") @@ -942,7 +943,7 @@ def test_get_runs_feed_filter_job_name(self, graphql_context): partition_set_origin = RemotePartitionSetOrigin( repository_origin=repository.get_remote_origin(), - partition_set_name="bar_partition", + partition_set_name=partition_set_snap_name_for_job_name("bar"), ) for _ in range(3): _create_run(graphql_context, job_name="bar")