From 091f096791c1a6847c0343629ed369434f08f673 Mon Sep 17 00:00:00 2001 From: Claire Lin Date: Tue, 19 Mar 2024 07:31:29 -0700 Subject: [PATCH] [ui] Asset catalog small design fixes (#20547) Adds two changes: - Ensures that on scroll all of the page content is displayed. Previously in certain situations the page was cut off. - Displays user's first name instead of full name. --- .../packages/ui-core/src/assets/AssetsOverview.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx index f356bbb6fbdde..5cc83de95ec2a 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsOverview.tsx @@ -264,6 +264,7 @@ export const AssetsOverview = ({viewerName}: {viewerName?: string}) => { timezone: [timezone], } = useContext(TimeContext); const recentlyVisitedAssets = fetchRecentlyVisitedAssetsFromLocalStorage(); + const viewerFirstName = viewerName?.split(' ')[0]; if (assetsQuery.loading) { return ( @@ -280,7 +281,7 @@ export const AssetsOverview = ({viewerName}: {viewerName?: string}) => { } return ( - <> + } @@ -291,7 +292,7 @@ export const AssetsOverview = ({viewerName}: {viewerName?: string}) => { {getGreeting(timezone)} - {viewerName ? `, ${viewerName}` : ''} + {viewerFirstName ? `, ${viewerFirstName}` : ''} View all @@ -388,7 +389,7 @@ export const AssetsOverview = ({viewerName}: {viewerName?: string}) => { )} - + ); };