From 0d1953bc28ba516f2b7e00c3c3d9315356469fbb Mon Sep 17 00:00:00 2001
From: Sean Quinlan <1011062+sbquinlan@users.noreply.github.com>
Date: Wed, 6 Nov 2024 09:04:08 -0800
Subject: [PATCH] Move types-sqlalchemy to requirements.txt (#25760)

Move types-sqlalchemy into managed pyright environment

## Summary & Motivation

If you're using sqlalchemy 2, then this type package is no longer correctly representing the sqlalchemy types. This change moves the pinned package into the managed pyright environment instead of being in the pyright extra.

## How I Tested These Changes

make pyright

## Changelog

The `types-sqlalchemy` package is no longer included in the `dagster[pyright]` extra package.
---
 pyright/master/requirements.txt | 2 ++
 python_modules/dagster/setup.py | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/pyright/master/requirements.txt b/pyright/master/requirements.txt
index 908bed6d5735a..24f7352b09d13 100644
--- a/pyright/master/requirements.txt
+++ b/pyright/master/requirements.txt
@@ -104,6 +104,8 @@ wordcloud  # (quickstart-*)
 # that trigger type errors
 apache-airflow>2.7
 pendulum<3
+types-sqlalchemy==1.4.53.34
+
 
 ### EXAMPLES
 
diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py
index bf835458f0c8c..fb1e355ebc401 100644
--- a/python_modules/dagster/setup.py
+++ b/python_modules/dagster/setup.py
@@ -155,7 +155,6 @@ def get_version() -> str:
             "types-requests",  # version will be resolved against requests
             "types-simplejson",  # version will be resolved against simplejson
             "types-six",  # needed but not specified by grpcio
-            "types-sqlalchemy==1.4.53.34",  # later versions introduce odd errors
             "types-tabulate",  # version will be resolved against tabulate
             "types-tzlocal",  # version will be resolved against tzlocal
             "types-toml",  # version will be resolved against toml