1 more ting

dagster-io · Dec 20, 2024 · 3eee5f6 · 3eee5f6
1 parent 7262f1e
commit 3eee5f6
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/Run.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/Run.tsx
@@ -105,7 +105,7 @@ export const Run = memo((props: RunProps) => {
       <LogsProvider key={runId} runId={runId}>
         {(logs) => (
           <>
-            <OnLogsLoaded dependency={logsDependency} />
+            <OnLogsLoaded dependency={logsDependency} logs={logs} />
             <RunMetadataProvider logs={logs}>
               {(metadata) => (
                 <RunWithData
@@ -128,10 +128,18 @@ export const Run = memo((props: RunProps) => {
   );
 });
 
-const OnLogsLoaded = ({dependency}: {dependency: ReturnType<typeof useTraceDependency>}) => {
+const OnLogsLoaded = ({
+  dependency,
+  logs,
+}: {
+  dependency: ReturnType<typeof useTraceDependency>;
+  logs: LogsProviderLogs;
+}) => {
   useLayoutEffect(() => {
-    dependency.completeDependency(CompletionType.SUCCESS);
-  }, [dependency]);
+    if (!logs.loading) {
+      dependency.completeDependency(CompletionType.SUCCESS);
+    }
+  }, [dependency, logs]);
   return null;
 };