From 716151a214c5498f8acf2d89bf96c8bbb29e87c8 Mon Sep 17 00:00:00 2001 From: jamiedemaria Date: Fri, 27 Sep 2024 11:42:49 -0400 Subject: [PATCH] disable run status popover for backfills in runs feed (#24842) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary & Motivation The RunStatusTagWithStats can't get stats for backfills, so instead we should show the non-stats RunStatusTag for backfills. I'm having an issue with the size of the tag though, the RunStatusTagWithStats is the expected size, but RunStatus tag is strangely wide Screenshot 2024-09-27 at 9 44 11 AM ## How I Tested These Changes 👀 ## Changelog NOCHANGELOG --- .../packages/ui-core/src/runs/RunsFeedRow.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedRow.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedRow.tsx index 10987643ce2f2..ad1017f4a283e 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedRow.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFeedRow.tsx @@ -16,7 +16,7 @@ import {CreatedByTagCell, CreatedByTagCellWrapper} from './CreatedByTag'; import {QueuedRunCriteriaDialog} from './QueuedRunCriteriaDialog'; import {RUN_ACTIONS_MENU_RUN_FRAGMENT, RunActionsMenu} from './RunActionsMenu'; import {RunRowTags} from './RunRowTags'; -import {RunStatusTagWithStats} from './RunStatusTag'; +import {RunStatusTag, RunStatusTagWithStats} from './RunStatusTag'; import {DagsterTag} from './RunTag'; import {RunTargetLink} from './RunTargetLink'; import {RunStateSummary, RunTime, titleForRun} from './RunUtils'; @@ -141,7 +141,13 @@ export const RunsFeedRow = ({ - +
+ {entry.__typename === 'PartitionBackfill' ? ( + + ) : ( + + )} +