From 87dfd5e0e4db6996163af04bd9fe7dd9215d7f73 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Wed, 3 Apr 2024 09:43:44 -0500 Subject: [PATCH] [ui] Make gantt boxes wider in non-timed views (#20976) Fixes #20482 ## Summary & Motivation ![image](https://github.com/dagster-io/dagster/assets/1037212/1a88a461-c877-4b79-a6c8-1f29db90598b) ![image](https://github.com/dagster-io/dagster/assets/1037212/78b46042-817f-45cb-9698-53a0e0f388ff) ## How I Tested These Changes --------- Co-authored-by: bengotow --- .../dagster-ui/packages/ui-core/src/gantt/Constants.ts | 2 +- .../ui-core/src/gantt/__tests__/GanttChartLayout.test.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/gantt/Constants.ts b/js_modules/dagster-ui/packages/ui-core/src/gantt/Constants.ts index b148a6b80f460..29bf641f35059 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/gantt/Constants.ts +++ b/js_modules/dagster-ui/packages/ui-core/src/gantt/Constants.ts @@ -56,7 +56,7 @@ export const FLAT_INSET_FROM_PARENT = 16; export const BOX_HEIGHT = 34; export const BOX_MARGIN_Y = 5; export const BOX_SPACING_X = 20; -export const BOX_WIDTH = 100; +export const BOX_WIDTH = 200; export const BOX_DOT_WIDTH_CUTOFF = 8; export const BOX_SHOW_LABEL_WIDTH_CUTOFF = 30; export const BOX_DOT_SIZE = 6; diff --git a/js_modules/dagster-ui/packages/ui-core/src/gantt/__tests__/GanttChartLayout.test.ts b/js_modules/dagster-ui/packages/ui-core/src/gantt/__tests__/GanttChartLayout.test.ts index a1c0548b068a6..ad9a68138a38d 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/gantt/__tests__/GanttChartLayout.test.ts +++ b/js_modules/dagster-ui/packages/ui-core/src/gantt/__tests__/GanttChartLayout.test.ts @@ -28,7 +28,7 @@ describe('toGraphQueryItems', () => { key: 'depends_on_nothing', root: true, state: undefined, - width: 100, + width: 200, x: 16, y: 0, }); @@ -37,8 +37,8 @@ describe('toGraphQueryItems', () => { key: 'depends_on_yesterday', root: false, state: undefined, - width: 100, - x: 152, + width: 200, + x: 252, y: 1, }); });