From af5df3e8e92baedb94249f4d2579ac766fdc560c Mon Sep 17 00:00:00 2001 From: Christopher DeCarolis Date: Thu, 10 Oct 2024 10:04:55 -0700 Subject: [PATCH] [dagster-airlift] Add python 3.8 support (#25151) ## Summary & Motivation In order to support 3.8, we need to place an upper bound on boto3 (older versions don't have access to mwaa). The version I chose is quite old, I don't anticipate this causing a problem. I guess with some resolvers it chooses a version pre-mwaa though, as that's why the tests were failing. ## How I Tested These Changes Tests now run on 3.8 ## Changelog NOCHANGELOG --- .../dagster-buildkite/dagster_buildkite/steps/packages.py | 1 - examples/experimental/dagster-airlift/setup.py | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py b/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py index dbdbe6da6a5d4..0ed0a9cb6fbd1 100644 --- a/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py +++ b/.buildkite/dagster-buildkite/dagster_buildkite/steps/packages.py @@ -361,7 +361,6 @@ def k8s_extra_cmds(version: str, _) -> List[str]: PackageSpec( "examples/experimental/dagster-airlift", unsupported_python_versions=[ - AvailablePythonVersion.V3_8, AvailablePythonVersion.V3_12, ], ), diff --git a/examples/experimental/dagster-airlift/setup.py b/examples/experimental/dagster-airlift/setup.py index f456cc706666c..4766662c94b4d 100644 --- a/examples/experimental/dagster-airlift/setup.py +++ b/examples/experimental/dagster-airlift/setup.py @@ -54,7 +54,9 @@ def get_version() -> str: f"dagster{pin}", ], "in-airflow": airflow_dep_list, - "mwaa": ["boto3"], + "mwaa": [ + "boto3>=1.18.0" + ], # confirms that mwaa is available in the environment (can't find exactly which version adds mwaa support, but I can confirm that 1.18.0 and greater have it.) "dbt": ["dagster-dbt"], "k8s": ["dagster-k8s"], "test": ["pytest", "dagster-dbt", "dbt-duckdb", "boto3", "dagster-webserver"],