From c7028793df8565ee30bfda95f5537811d52bee44 Mon Sep 17 00:00:00 2001
From: Marco polo <salazarm@users.noreply.github.com>
Date: Tue, 6 Aug 2024 15:12:32 -0400
Subject: [PATCH] Don't propagate click events from popover + remove
 unnecessary overflow hidden (#23443)

## Summary & Motivation

1. Don't propagate click events from the popover of ProductTour since by
default blueprint's `Popover` seems to bubble them up to the element its
wrapping (super weird!).
2. Remove overflow: hidden from the AssetPageHeader because this wraps a
button that uses outerglow on hover and the overflow hidden ends up
hiding the outerglow making it look weird.

(cherry picked from commit f3ce9a89e0eb504234b328d46dc5ce3e71661934)
---
 .../packages/ui-components/src/components/ProductTour.tsx | 8 ++++++--
 .../packages/ui-core/src/assets/AssetPageHeader.oss.tsx   | 5 +----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/js_modules/dagster-ui/packages/ui-components/src/components/ProductTour.tsx b/js_modules/dagster-ui/packages/ui-components/src/components/ProductTour.tsx
index 92275b6e1d16b..b8dfac3422faf 100644
--- a/js_modules/dagster-ui/packages/ui-components/src/components/ProductTour.tsx
+++ b/js_modules/dagster-ui/packages/ui-components/src/components/ProductTour.tsx
@@ -84,7 +84,11 @@ export const ProductTour = ({
       }}
       minimal={false}
       content={
-        <>
+        <div
+          onClick={(ev) => {
+            ev.stopPropagation();
+          }}
+        >
           <div />
           <ProductTourContainer flex={{direction: 'column', gap: 4}} padding={16} style={{width}}>
             <Box flex={{direction: 'column', gap: 8}}>
@@ -95,7 +99,7 @@ export const ProductTour = ({
             {actionsJsx}
           </ProductTourContainer>
           <div />
-        </>
+        </div>
       }
     >
       {children}
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetPageHeader.oss.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetPageHeader.oss.tsx
index a7a44b583c53c..6572709b1bafa 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetPageHeader.oss.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetPageHeader.oss.tsx
@@ -71,10 +71,7 @@ export const AssetPageHeader = ({
   return (
     <PageHeader
       title={
-        <Box
-          flex={{alignItems: 'center', gap: 4}}
-          style={{maxWidth: '600px', overflow: 'hidden', marginBottom: 4}}
-        >
+        <Box flex={{alignItems: 'center', gap: 4}} style={{maxWidth: '600px', marginBottom: 4}}>
           <Title>
             <BreadcrumbsWithSlashes
               items={breadcrumbs}