From cbc2ac8feeb1d2d7b6277d6804ab67d96bec7a54 Mon Sep 17 00:00:00 2001 From: Maxime Armstrong <46797220+maximearmstrong@users.noreply.github.com> Date: Tue, 22 Oct 2024 17:28:12 -0400 Subject: [PATCH] [dagster-tableau] Pin tableauserverclient version (#25441) ## Summary & Motivation `dagster-tableau` tests fail [here](https://buildkite.com/dagster/dagster-dagster/builds/99632#0192b583-1d7e-42fe-8973-3f0db3a12b3c) for Python 3.8. For some reasons, pip installed `tableauserverclient==0.19` for these tests, which has a different implementation of `TSC.Server()` that is not compatible with our implementation. After investigating and testing locally, our implementation requires at least `tableauserverclient` version 0.32, which is the first version to implement the Datasources endpoint. This PR pins `tableauserverclient>=0.32` in setup.py, which is compatible with Python 3.7+. ## How I Tested These Changes Tested locally with Python 3.8.19 and 3.11.9 --- python_modules/libraries/dagster-tableau/setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python_modules/libraries/dagster-tableau/setup.py b/python_modules/libraries/dagster-tableau/setup.py index aa22d9be1993f..6df3478c61625 100644 --- a/python_modules/libraries/dagster-tableau/setup.py +++ b/python_modules/libraries/dagster-tableau/setup.py @@ -38,7 +38,8 @@ def get_version() -> str: install_requires=[ f"dagster{pin}", "pyjwt[crypto]", - "tableauserverclient", + # Datasources endpoint were added in 0.32 + "tableauserverclient>=0.32", ], include_package_data=True, python_requires=">=3.8,<3.13",