From d3720b489d04cb634eb14b5a099b45f5ba0002b9 Mon Sep 17 00:00:00 2001 From: Sean Mackesey Date: Tue, 19 Mar 2024 10:39:32 -0400 Subject: [PATCH] [bugfix] Fix regression in ExternalAssetNode metadata (#20558) ## Summary & Motivation A previous refactor introduced a regression by failing to normalize `ExternalAssetNode` metadata with `allow_invalid=True`. This fixes the regression. ## How I Tested These Changes Existing test suite. --- .../dagster/_core/remote_representation/external_data.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python_modules/dagster/dagster/_core/remote_representation/external_data.py b/python_modules/dagster/dagster/_core/remote_representation/external_data.py index 19c06a75d95c3..6cb110fd2687d 100644 --- a/python_modules/dagster/dagster/_core/remote_representation/external_data.py +++ b/python_modules/dagster/dagster/_core/remote_representation/external_data.py @@ -1239,7 +1239,9 @@ def __new__( auto_observe_interval_minutes: Optional[float] = None, owners: Optional[Sequence[str]] = None, ): - metadata = normalize_metadata(check.opt_mapping_param(metadata, "metadata", key_type=str)) + metadata = normalize_metadata( + check.opt_mapping_param(metadata, "metadata", key_type=str), allow_invalid=True + ) # backcompat logic for execution type specified via metadata if SYSTEM_METADATA_KEY_ASSET_EXECUTION_TYPE in metadata: