Skip to content

Commit

Permalink
[ez][Asset graph] revert padding change (#16942)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Reverting a padding change I made that tried to solve one problem but
created another. I solved the original problem in a separate PR.

before:
<img width="1491" alt="Screenshot 2023-10-02 at 8 37 19 AM"
src="https://github.com/dagster-io/dagster/assets/2286579/3218bb3c-2f89-4c3e-91c1-b09149c98f94">


after:
<img width="1492" alt="Screenshot 2023-10-02 at 8 36 44 AM"
src="https://github.com/dagster-io/dagster/assets/2286579/2d693866-be7c-4ea1-9f2f-0c7eb605fd90">

## How I Tested These Changes
  • Loading branch information
salazarm authored Oct 2, 2023
1 parent 3b99397 commit efea247
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,17 @@ interface Props {
metadata?: React.ReactNode;
right?: React.ReactNode;
tabs?: React.ReactNode;
paddingBelowTitle?: number;
}

export const PageHeader = (props: Props) => {
const {title, tags, right, tabs, paddingBelowTitle = 16} = props;
const {title, tags, right, tabs} = props;
return (
<PageHeaderContainer
background={Colors.Gray50}
padding={{top: 16, left: 24, right: 12}}
border="bottom"
>
<Box
flex={{direction: 'row', justifyContent: 'space-between'}}
padding={{bottom: paddingBelowTitle as any}}
>
<Box flex={{direction: 'row', justifyContent: 'space-between'}} padding={{bottom: 16}}>
<Box flex={{direction: 'row', alignItems: 'flex-start', gap: 12, wrap: 'wrap'}}>
{title}
{tags}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export const AssetGroupRoot: React.FC<{repoAddress: RepoAddress; tab: 'lineage'
<PageHeader
title={<Heading>{groupName}</Heading>}
right={<ReloadAllButton label="Reload definitions" />}
paddingBelowTitle={0}
tags={<AssetGroupTags groupSelector={groupSelector} repoAddress={repoAddress} />}
tabs={
<Box
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ export const AssetsGroupsGlobalGraphRoot: React.FC = () => {
<Page style={{display: 'flex', flexDirection: 'column', paddingBottom: 0}}>
<PageHeader
title={<Heading>Global Asset Lineage</Heading>}
paddingBelowTitle={0}
right={<ReloadAllButton label="Reload definitions" />}
/>
<AssetGraphExplorer
Expand Down

2 comments on commit efea247

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-58y9mhq5x-elementl.vercel.app

Built with commit efea247.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-m4zsqsb3t-elementl.vercel.app

Built with commit efea247.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.