From f84b5b8b85245ef48be0cb9c44d4e67327eeb005 Mon Sep 17 00:00:00 2001 From: Claire Lin Date: Tue, 5 Nov 2024 14:59:58 -0800 Subject: [PATCH] Add table name filter type (#25346) Corresponding internal PR: https://github.com/dagster-io/internal/pull/12126 --- .../dagster-ui/packages/ui-core/src/search/SearchResults.tsx | 4 ++++ js_modules/dagster-ui/packages/ui-core/src/search/types.ts | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx b/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx index ae3ce42f2b4f1..3f240e77cfab7 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/search/SearchResults.tsx @@ -59,6 +59,8 @@ const iconForType = (type: SearchResultType | AssetFilterSearchResultType): Icon return 'view_column'; case AssetFilterSearchResultType.ColumnTag: return 'tag'; + case AssetFilterSearchResultType.TableName: + return 'database'; default: assertUnreachable(type); } @@ -80,6 +82,8 @@ const assetFilterPrefixString = (type: AssetFilterSearchResultType): string => { return 'Column'; case AssetFilterSearchResultType.ColumnTag: return 'Column tag'; + case AssetFilterSearchResultType.TableName: + return 'Table name'; default: assertUnreachable(type); } diff --git a/js_modules/dagster-ui/packages/ui-core/src/search/types.ts b/js_modules/dagster-ui/packages/ui-core/src/search/types.ts index da68a1b8915b2..a9d346c9e0128 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/search/types.ts +++ b/js_modules/dagster-ui/packages/ui-core/src/search/types.ts @@ -35,6 +35,7 @@ export enum AssetFilterSearchResultType { AssetGroup = 'AssetFilterSearchResultType.AssetGroup', Column = 'AssetFilterSearchResultType.Column', ColumnTag = 'AssetFilterSearchResultType.ColumnTag', + TableName = 'AssetFilterSearchResultType.TableName', } export function isAssetFilterSearchResultType( @@ -47,7 +48,8 @@ export function isAssetFilterSearchResultType( type === AssetFilterSearchResultType.Owner || type === AssetFilterSearchResultType.Tag || type === AssetFilterSearchResultType.Column || - type === AssetFilterSearchResultType.ColumnTag + type === AssetFilterSearchResultType.ColumnTag || + type === AssetFilterSearchResultType.TableName ); }