From f94fa1c1d17613764d71061fc9bc5035c3bc73cf Mon Sep 17 00:00:00 2001 From: Neil Fulwiler Date: Thu, 5 Sep 2024 14:33:25 -0400 Subject: [PATCH] pin pydantic < 2.9.0 (#24258) ## Summary & Motivation pydantic 2.9.0 (released 2024-09-05) introduces some breaking changes causing | `TableMetadataSet` is not fully defined; you should define `TableColumn`, then call `TableMetadataSet.model_rebuild()`. pinning to <2.9.0 should fix this ## How I Tested These Changes existing tests Co-authored-by: Neil Fulwiler (cherry picked from commit 0875c0b3ca05938e7c81ffb32578ec711c0ce2eb) --- examples/temp_pins.txt | 1 + python_modules/dagster/setup.py | 2 +- python_modules/libraries/dagster-datahub/setup.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/temp_pins.txt b/examples/temp_pins.txt index 2f12e174d2ca1..eb76448c1f9ad 100644 --- a/examples/temp_pins.txt +++ b/examples/temp_pins.txt @@ -11,3 +11,4 @@ # temporarily introduce pins for these tests until the next version of # Dagster is published to PyPI. responses==0.23.1 +pydantic<2.9.0 diff --git a/python_modules/dagster/setup.py b/python_modules/dagster/setup.py index 0a1a08dbd53ed..b3235c95655c7 100644 --- a/python_modules/dagster/setup.py +++ b/python_modules/dagster/setup.py @@ -110,7 +110,7 @@ def get_version() -> str: "universal_pathlib; python_version<'3.12'", "universal_pathlib>=0.2.0; python_version>='3.12'", # https://github.com/pydantic/pydantic/issues/5821 - "pydantic>1.10.0,!= 1.10.7,<3", + "pydantic>1.10.0,!= 1.10.7,<2.9.0", "rich", "filelock", f"dagster-pipes{pin}", diff --git a/python_modules/libraries/dagster-datahub/setup.py b/python_modules/libraries/dagster-datahub/setup.py index a83d42e37ce34..812d147551d5a 100644 --- a/python_modules/libraries/dagster-datahub/setup.py +++ b/python_modules/libraries/dagster-datahub/setup.py @@ -42,7 +42,7 @@ def get_version() -> str: f"dagster{pin}", "packaging", "requests", - "pydantic>=1.10.0,<3.0.0", + "pydantic>=1.10.0,<2.9.0", ], extras_require={}, zip_safe=False,