From f9ba3649648bc3c0ecee420800aacdfc39e4a79a Mon Sep 17 00:00:00 2001 From: Alex Langenfeld Date: Mon, 18 Nov 2024 11:58:00 -0600 Subject: [PATCH] [graphql] fix backfill target keys (#25964) in https://github.com/dagster-io/dagster/pull/25736 I mistakenly thought filtering down to the nodes in the target set in the first pass would act as the previous `if k in self.target_subset.asset_keys` but the list becomes filled with `parent_keys` so need to preserve that check ## How I Tested These Changes updated test so it failed without this fix ## Changelog [ui] no longer display extraneous assets in the asset backfill page, a problem introduced in 1.9.2 --- .../__snapshots__/test_all_snapshot_ids.ambr | 1540 +++++++++-------- .../graphql/__snapshots__/test_assets.ambr | 13 + .../graphql/__snapshots__/test_solids.ambr | 16 + .../dagster_graphql_tests/graphql/repo.py | 7 +- .../dagster/_core/execution/asset_backfill.py | 1 + 5 files changed, 845 insertions(+), 732 deletions(-) diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_all_snapshot_ids.ambr b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_all_snapshot_ids.ambr index 931398a75aafc..a3d7ea283166c 100644 --- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_all_snapshot_ids.ambr +++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_all_snapshot_ids.ambr @@ -489,309 +489,7 @@ "scalar_kind": null, "type_param_keys": null }, - "Shape.2b5e6e2b190fb25e32288ec068c8ff7fb8db3014": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{\"config\": {\"retries\": {\"enabled\": {}}}}", - "description": "Configure how steps are executed within a run.", - "is_required": false, - "name": "execution", - "type_key": "Shape.09d73f0755bf4752d3f121837669c8660dcf451e" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": "Configure how loggers emit messages within a run.", - "is_required": false, - "name": "loggers", - "type_key": "Shape.e895d95ee6d0eff1b884c76f44a2ab7089f0c49b" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{\"asset_1\": {}, \"asset_1_my_check\": {}, \"asset_2\": {}, \"asset_3\": {}, \"asset_one\": {}, \"asset_two\": {}, \"asset_with_automation_condition\": {}, \"asset_with_compute_storage_kinds\": {\"config\": {}}, \"asset_with_custom_automation_condition\": {}, \"asset_yields_observation\": {}, \"bar\": {}, \"baz\": {}, \"check_in_op_asset\": {}, \"downstream_asset\": {}, \"downstream_dynamic_partitioned_asset\": {}, \"downstream_static_partitioned_asset\": {}, \"downstream_time_partitioned_asset\": {}, \"downstream_weekly_partitioned_asset\": {}, \"dynamic_in_multipartitions_fail\": {}, \"dynamic_in_multipartitions_success\": {}, \"executable_asset\": {}, \"fail_partition_materialization\": {}, \"first_asset\": {}, \"foo\": {}, \"foo_bar\": {}, \"fresh_diamond_bottom\": {}, \"fresh_diamond_left\": {}, \"fresh_diamond_right\": {}, \"fresh_diamond_top\": {}, \"grouped_asset_1\": {}, \"grouped_asset_2\": {}, \"grouped_asset_4\": {}, \"hanging_asset\": {}, \"hanging_graph\": {\"ops\": {\"hanging_op\": {}, \"my_op\": {}, \"never_runs_op\": {}}}, \"hanging_partition_asset\": {}, \"integers_asset\": {}, \"middle_static_partitioned_asset_1\": {}, \"middle_static_partitioned_asset_2\": {}, \"multi_asset_with_kinds\": {\"config\": {}}, \"multi_run_backfill_policy_asset\": {}, \"multipartitions_1\": {}, \"multipartitions_2\": {}, \"multipartitions_fail\": {}, \"never_runs_asset\": {}, \"no_multipartitions_1\": {}, \"output_then_hang_asset\": {}, \"single_run_backfill_policy_asset\": {}, \"subsettable_checked_multi_asset\": {\"config\": {}}, \"typed_asset\": {}, \"typed_multi_asset\": {\"config\": {}}, \"unconnected\": {}, \"ungrouped_asset_3\": {}, \"ungrouped_asset_5\": {}, \"unpartitioned_upstream_of_partitioned\": {}, \"untyped_asset\": {}, \"upstream_daily_partitioned_asset\": {}, \"upstream_dynamic_partitioned_asset\": {}, \"upstream_static_partitioned_asset\": {}, \"upstream_time_partitioned_asset\": {}, \"yield_partition_materialization\": {}}", - "description": "Configure runtime parameters for ops or assets.", - "is_required": false, - "name": "ops", - "type_key": "Shape.a5a176434a175a95d1824c99b433d2da5d2d1fcf" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": "Configure how shared resources are implemented within a run.", - "is_required": true, - "name": "resources", - "type_key": "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f" - } - ], - "given_name": null, - "key": "Shape.2b5e6e2b190fb25e32288ec068c8ff7fb8db3014", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.35d3e42b53e66506c5867f04644849cd03763bc6": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{\"hanging_op\": {}, \"my_op\": {}, \"never_runs_op\": {}}", - "description": null, - "is_required": false, - "name": "ops", - "type_key": "Shape.811a60b4c43530c3d6100304f377dbd2d3045291" - } - ], - "given_name": null, - "key": "Shape.35d3e42b53e66506c5867f04644849cd03763bc6", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.44f24ac55059da1634e84af6c1bf7e0ed332251c": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": "[DEPRECATED]", - "is_required": false, - "name": "marker_to_close", - "type_key": "String" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{\"enabled\": {}}", - "description": "Whether retries are enabled or not. By default, retries are enabled.", - "is_required": false, - "name": "retries", - "type_key": "Selector.1bfb167aea90780aa679597800c71bd8c65ed0b2" - } - ], - "given_name": null, - "key": "Shape.44f24ac55059da1634e84af6c1bf7e0ed332251c", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.44f2a71367507edd1b8e64f739222c4312b3691b": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "config", - "type_key": "Shape.18b2faaf1efd505374f7f25fcb61ed59bd5be851" - } - ], - "given_name": null, - "key": "Shape.44f2a71367507edd1b8e64f739222c4312b3691b", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.4b53b73df342381d0d05c5f36183dc99cb9676e2": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": true, - "name": "path", - "type_key": "String" - } - ], - "given_name": null, - "key": "Shape.4b53b73df342381d0d05c5f36183dc99cb9676e2", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.62edccaf30696e25335ae92685bdc41e204e30e6": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "config", - "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" - } - ], - "given_name": null, - "key": "Shape.62edccaf30696e25335ae92685bdc41e204e30e6", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.743e47901855cb245064dd633e217bfcb49a11a7": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - } - ], - "given_name": null, - "key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "dummy_io_manager", - "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": true, - "name": "hanging_asset_resource", - "type_key": "Shape.b13a6c5637084590cc1538f9522324bfeb4b46b3" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{\"config\": {}}", - "description": "Built-in filesystem IO manager that stores and retrieves values using pickling.", - "is_required": false, - "name": "io_manager", - "type_key": "Shape.44f2a71367507edd1b8e64f739222c4312b3691b" - } - ], - "given_name": null, - "key": "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.811a60b4c43530c3d6100304f377dbd2d3045291": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "hanging_op", - "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "my_op", - "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" - }, - { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "never_runs_op", - "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" - } - ], - "given_name": null, - "key": "Shape.811a60b4c43530c3d6100304f377dbd2d3045291", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.9a3a315bff2146cca750edbec49c6b4b4d0ce58e": { - "__class__": "ConfigTypeSnap", - "description": null, - "enum_values": null, - "fields": [ - { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": true, - "name": "file", - "type_key": "String" - } - ], - "given_name": null, - "key": "Shape.9a3a315bff2146cca750edbec49c6b4b4d0ce58e", - "kind": { - "__enum__": "ConfigTypeKind.STRICT_SHAPE" - }, - "scalar_kind": null, - "type_param_keys": null - }, - "Shape.a5a176434a175a95d1824c99b433d2da5d2d1fcf": { + "Shape.2923e2efed8c6ae4999833e86ce030061009998f": { "__class__": "ConfigTypeSnap", "description": null, "enum_values": null, @@ -1201,6 +899,15 @@ "name": "no_multipartitions_1", "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "not_included_asset", + "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" + }, { "__class__": "ConfigFieldSnap", "default_provided": true, @@ -1338,7 +1045,309 @@ } ], "given_name": null, - "key": "Shape.a5a176434a175a95d1824c99b433d2da5d2d1fcf", + "key": "Shape.2923e2efed8c6ae4999833e86ce030061009998f", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.35d3e42b53e66506c5867f04644849cd03763bc6": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{\"hanging_op\": {}, \"my_op\": {}, \"never_runs_op\": {}}", + "description": null, + "is_required": false, + "name": "ops", + "type_key": "Shape.811a60b4c43530c3d6100304f377dbd2d3045291" + } + ], + "given_name": null, + "key": "Shape.35d3e42b53e66506c5867f04644849cd03763bc6", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.44f24ac55059da1634e84af6c1bf7e0ed332251c": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": "[DEPRECATED]", + "is_required": false, + "name": "marker_to_close", + "type_key": "String" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{\"enabled\": {}}", + "description": "Whether retries are enabled or not. By default, retries are enabled.", + "is_required": false, + "name": "retries", + "type_key": "Selector.1bfb167aea90780aa679597800c71bd8c65ed0b2" + } + ], + "given_name": null, + "key": "Shape.44f24ac55059da1634e84af6c1bf7e0ed332251c", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.44f2a71367507edd1b8e64f739222c4312b3691b": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "config", + "type_key": "Shape.18b2faaf1efd505374f7f25fcb61ed59bd5be851" + } + ], + "given_name": null, + "key": "Shape.44f2a71367507edd1b8e64f739222c4312b3691b", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.4b53b73df342381d0d05c5f36183dc99cb9676e2": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": true, + "name": "path", + "type_key": "String" + } + ], + "given_name": null, + "key": "Shape.4b53b73df342381d0d05c5f36183dc99cb9676e2", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.62edccaf30696e25335ae92685bdc41e204e30e6": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "config", + "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" + } + ], + "given_name": null, + "key": "Shape.62edccaf30696e25335ae92685bdc41e204e30e6", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.6c71186a8f3069ee444291a42734fb8144db65fe": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{\"config\": {\"retries\": {\"enabled\": {}}}}", + "description": "Configure how steps are executed within a run.", + "is_required": false, + "name": "execution", + "type_key": "Shape.09d73f0755bf4752d3f121837669c8660dcf451e" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": "Configure how loggers emit messages within a run.", + "is_required": false, + "name": "loggers", + "type_key": "Shape.e895d95ee6d0eff1b884c76f44a2ab7089f0c49b" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{\"asset_1\": {}, \"asset_1_my_check\": {}, \"asset_2\": {}, \"asset_3\": {}, \"asset_one\": {}, \"asset_two\": {}, \"asset_with_automation_condition\": {}, \"asset_with_compute_storage_kinds\": {\"config\": {}}, \"asset_with_custom_automation_condition\": {}, \"asset_yields_observation\": {}, \"bar\": {}, \"baz\": {}, \"check_in_op_asset\": {}, \"downstream_asset\": {}, \"downstream_dynamic_partitioned_asset\": {}, \"downstream_static_partitioned_asset\": {}, \"downstream_time_partitioned_asset\": {}, \"downstream_weekly_partitioned_asset\": {}, \"dynamic_in_multipartitions_fail\": {}, \"dynamic_in_multipartitions_success\": {}, \"executable_asset\": {}, \"fail_partition_materialization\": {}, \"first_asset\": {}, \"foo\": {}, \"foo_bar\": {}, \"fresh_diamond_bottom\": {}, \"fresh_diamond_left\": {}, \"fresh_diamond_right\": {}, \"fresh_diamond_top\": {}, \"grouped_asset_1\": {}, \"grouped_asset_2\": {}, \"grouped_asset_4\": {}, \"hanging_asset\": {}, \"hanging_graph\": {\"ops\": {\"hanging_op\": {}, \"my_op\": {}, \"never_runs_op\": {}}}, \"hanging_partition_asset\": {}, \"integers_asset\": {}, \"middle_static_partitioned_asset_1\": {}, \"middle_static_partitioned_asset_2\": {}, \"multi_asset_with_kinds\": {\"config\": {}}, \"multi_run_backfill_policy_asset\": {}, \"multipartitions_1\": {}, \"multipartitions_2\": {}, \"multipartitions_fail\": {}, \"never_runs_asset\": {}, \"no_multipartitions_1\": {}, \"not_included_asset\": {}, \"output_then_hang_asset\": {}, \"single_run_backfill_policy_asset\": {}, \"subsettable_checked_multi_asset\": {\"config\": {}}, \"typed_asset\": {}, \"typed_multi_asset\": {\"config\": {}}, \"unconnected\": {}, \"ungrouped_asset_3\": {}, \"ungrouped_asset_5\": {}, \"unpartitioned_upstream_of_partitioned\": {}, \"untyped_asset\": {}, \"upstream_daily_partitioned_asset\": {}, \"upstream_dynamic_partitioned_asset\": {}, \"upstream_static_partitioned_asset\": {}, \"upstream_time_partitioned_asset\": {}, \"yield_partition_materialization\": {}}", + "description": "Configure runtime parameters for ops or assets.", + "is_required": false, + "name": "ops", + "type_key": "Shape.2923e2efed8c6ae4999833e86ce030061009998f" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": "Configure how shared resources are implemented within a run.", + "is_required": true, + "name": "resources", + "type_key": "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f" + } + ], + "given_name": null, + "key": "Shape.6c71186a8f3069ee444291a42734fb8144db65fe", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.743e47901855cb245064dd633e217bfcb49a11a7": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + } + ], + "given_name": null, + "key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "dummy_io_manager", + "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": true, + "name": "hanging_asset_resource", + "type_key": "Shape.b13a6c5637084590cc1538f9522324bfeb4b46b3" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{\"config\": {}}", + "description": "Built-in filesystem IO manager that stores and retrieves values using pickling.", + "is_required": false, + "name": "io_manager", + "type_key": "Shape.44f2a71367507edd1b8e64f739222c4312b3691b" + } + ], + "given_name": null, + "key": "Shape.7493b137e48f8d4b013bce61e92617ff1bc51f7f", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.811a60b4c43530c3d6100304f377dbd2d3045291": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "hanging_op", + "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "my_op", + "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" + }, + { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "never_runs_op", + "type_key": "Shape.743e47901855cb245064dd633e217bfcb49a11a7" + } + ], + "given_name": null, + "key": "Shape.811a60b4c43530c3d6100304f377dbd2d3045291", + "kind": { + "__enum__": "ConfigTypeKind.STRICT_SHAPE" + }, + "scalar_kind": null, + "type_param_keys": null + }, + "Shape.9a3a315bff2146cca750edbec49c6b4b4d0ce58e": { + "__class__": "ConfigTypeSnap", + "description": null, + "enum_values": null, + "fields": [ + { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": true, + "name": "file", + "type_key": "String" + } + ], + "given_name": null, + "key": "Shape.9a3a315bff2146cca750edbec49c6b4b4d0ce58e", "kind": { "__enum__": "ConfigTypeKind.STRICT_SHAPE" }, @@ -2225,6 +2234,14 @@ "solid_name": "no_multipartitions_1", "tags": {} }, + { + "__class__": "SolidInvocationSnap", + "input_dep_snaps": [], + "is_dynamic_mapped": false, + "solid_def_name": "not_included_asset", + "solid_name": "not_included_asset", + "tags": {} + }, { "__class__": "SolidInvocationSnap", "input_dep_snaps": [], @@ -2362,7 +2379,20 @@ }, { "__class__": "SolidInvocationSnap", - "input_dep_snaps": [], + "input_dep_snaps": [ + { + "__class__": "InputDependencySnap", + "input_name": "not_included_asset", + "is_dynamic_collect": false, + "upstream_output_snaps": [ + { + "__class__": "OutputHandleSnap", + "output_name": "result", + "solid_name": "not_included_asset" + } + ] + } + ], "is_dynamic_mapped": false, "solid_def_name": "upstream_static_partitioned_asset", "solid_name": "upstream_static_partitioned_asset", @@ -2454,7 +2484,7 @@ "name": "io_manager" } ], - "root_config_key": "Shape.2b5e6e2b190fb25e32288ec068c8ff7fb8db3014" + "root_config_key": "Shape.6c71186a8f3069ee444291a42734fb8144db65fe" } ], "name": "__ASSET_JOB", @@ -2661,12 +2691,321 @@ "input_def_snaps": [ { "__class__": "InputDefSnap", - "dagster_type_key": "Nothing", + "dagster_type_key": "Nothing", + "description": null, + "name": "asset_2" + } + ], + "name": "asset_3", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "asset_one", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "asset_one" + } + ], + "name": "asset_two", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "asset_with_automation_condition", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Nothing", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": true, + "default_value_as_json_str": "{}", + "description": null, + "is_required": false, + "name": "config", + "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" + }, + "description": null, + "input_def_snaps": [], + "name": "asset_with_compute_storage_kinds", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Nothing", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "third_kinds_key" + }, + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Nothing", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "fourth_kinds_key" + } + ], + "required_resource_keys": [], + "tags": { + "dagster/compute_kind": "python" + } + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "asset_with_custom_automation_condition", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Nothing", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "asset_yields_observation", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "bar", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "foo_bar" + } + ], + "name": "baz", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [], + "name": "check_in_op_asset", + "output_def_snaps": [ + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "result" + }, + { + "__class__": "OutputDefSnap", + "dagster_type_key": "Any", + "description": null, + "is_dynamic": false, + "is_required": true, + "name": "check_in_op_asset_my_check" + } + ], + "required_resource_keys": [], + "tags": {} + }, + { + "__class__": "SolidDefSnap", + "config_field_snap": { + "__class__": "ConfigFieldSnap", + "default_provided": false, + "default_value_as_json_str": null, + "description": null, + "is_required": false, + "name": "config", + "type_key": "Any" + }, + "description": null, + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", "description": null, - "name": "asset_2" + "name": "hanging_graph" } ], - "name": "asset_3", + "name": "downstream_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2692,8 +3031,15 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], - "name": "asset_one", + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "upstream_dynamic_partitioned_asset" + } + ], + "name": "downstream_dynamic_partitioned_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2724,10 +3070,16 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "asset_one" + "name": "middle_static_partitioned_asset_1" + }, + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "middle_static_partitioned_asset_2" } ], - "name": "asset_two", + "name": "downstream_static_partitioned_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2753,57 +3105,27 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], - "name": "asset_with_automation_condition", - "output_def_snaps": [ + "input_def_snaps": [ { - "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", + "__class__": "InputDefSnap", + "dagster_type_key": "Any", "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" + "name": "upstream_time_partitioned_asset" } ], - "required_resource_keys": [], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "config", - "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" - }, - "description": null, - "input_def_snaps": [], - "name": "asset_with_compute_storage_kinds", + "name": "downstream_time_partitioned_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "third_kinds_key" - }, - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", + "dagster_type_key": "Any", "description": null, "is_dynamic": false, "is_required": true, - "name": "fourth_kinds_key" + "name": "result" } ], "required_resource_keys": [], - "tags": { - "dagster/compute_kind": "python" - } + "tags": {} }, { "__class__": "SolidDefSnap", @@ -2817,12 +3139,19 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], - "name": "asset_with_custom_automation_condition", + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "upstream_daily_partitioned_asset" + } + ], + "name": "downstream_weekly_partitioned_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", + "dagster_type_key": "Any", "description": null, "is_dynamic": false, "is_required": true, @@ -2844,8 +3173,15 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], - "name": "asset_yields_observation", + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "dynamic_in_multipartitions_success" + } + ], + "name": "dynamic_in_multipartitions_fail", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2872,7 +3208,7 @@ }, "description": null, "input_def_snaps": [], - "name": "bar", + "name": "dynamic_in_multipartitions_success", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2903,14 +3239,14 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "foo_bar" + "name": "unexecutable_asset" } ], - "name": "baz", + "name": "executable_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", - "dagster_type_key": "Any", + "dagster_type_key": "Nothing", "description": null, "is_dynamic": false, "is_required": true, @@ -2933,7 +3269,7 @@ }, "description": null, "input_def_snaps": [], - "name": "check_in_op_asset", + "name": "fail_partition_materialization", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -2942,14 +3278,6 @@ "is_dynamic": false, "is_required": true, "name": "result" - }, - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "check_in_op_asset_my_check" } ], "required_resource_keys": [], @@ -2972,10 +3300,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "hanging_graph" + "name": "dummy_source_asset" } ], - "name": "downstream_asset", + "name": "first_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3001,15 +3329,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "upstream_dynamic_partitioned_asset" - } - ], - "name": "downstream_dynamic_partitioned_asset", + "input_def_snaps": [], + "name": "foo", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3040,16 +3361,16 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "middle_static_partitioned_asset_1" + "name": "bar" }, { "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "middle_static_partitioned_asset_2" + "name": "foo" } ], - "name": "downstream_static_partitioned_asset", + "name": "foo_bar", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3080,10 +3401,16 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "upstream_time_partitioned_asset" + "name": "fresh_diamond_left" + }, + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "fresh_diamond_right" } ], - "name": "downstream_time_partitioned_asset", + "name": "fresh_diamond_bottom", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3114,10 +3441,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "upstream_daily_partitioned_asset" + "name": "fresh_diamond_top" } ], - "name": "downstream_weekly_partitioned_asset", + "name": "fresh_diamond_left", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3148,10 +3475,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "dynamic_in_multipartitions_success" + "name": "fresh_diamond_top" } ], - "name": "dynamic_in_multipartitions_fail", + "name": "fresh_diamond_right", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3177,8 +3504,15 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], - "name": "dynamic_in_multipartitions_success", + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Nothing", + "description": null, + "name": "diamond_source" + } + ], + "name": "fresh_diamond_top", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3204,19 +3538,12 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "unexecutable_asset" - } - ], - "name": "executable_asset", + "input_def_snaps": [], + "name": "grouped_asset_1", "output_def_snaps": [ { "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", + "dagster_type_key": "Any", "description": null, "is_dynamic": false, "is_required": true, @@ -3239,7 +3566,7 @@ }, "description": null, "input_def_snaps": [], - "name": "fail_partition_materialization", + "name": "grouped_asset_2", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3265,15 +3592,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "dummy_source_asset" - } - ], - "name": "first_asset", + "input_def_snaps": [], + "name": "grouped_asset_4", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3298,9 +3618,16 @@ "name": "config", "type_key": "Any" }, - "description": null, - "input_def_snaps": [], - "name": "foo", + "description": "Asset that hangs forever, used to test in-progress ops.", + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "first_asset" + } + ], + "name": "hanging_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3311,7 +3638,9 @@ "name": "result" } ], - "required_resource_keys": [], + "required_resource_keys": [ + "hanging_asset_resource" + ], "tags": {} }, { @@ -3331,16 +3660,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "bar" - }, - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "foo" + "name": "my_op" } ], - "name": "foo_bar", + "name": "hanging_op", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3351,7 +3674,9 @@ "name": "result" } ], - "required_resource_keys": [], + "required_resource_keys": [ + "hanging_asset_resource" + ], "tags": {} }, { @@ -3366,21 +3691,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "fresh_diamond_left" - }, - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "fresh_diamond_right" - } - ], - "name": "fresh_diamond_bottom", + "input_def_snaps": [], + "name": "hanging_partition_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3391,7 +3703,9 @@ "name": "result" } ], - "required_resource_keys": [], + "required_resource_keys": [ + "hanging_asset_resource" + ], "tags": {} }, { @@ -3406,15 +3720,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "fresh_diamond_top" - } - ], - "name": "fresh_diamond_left", + "input_def_snaps": [], + "name": "integers_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3445,10 +3752,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "fresh_diamond_top" + "name": "upstream_static_partitioned_asset" } ], - "name": "fresh_diamond_right", + "name": "middle_static_partitioned_asset_1", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3477,39 +3784,12 @@ "input_def_snaps": [ { "__class__": "InputDefSnap", - "dagster_type_key": "Nothing", - "description": null, - "name": "diamond_source" - } - ], - "name": "fresh_diamond_top", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", "dagster_type_key": "Any", "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" + "name": "upstream_static_partitioned_asset" } ], - "required_resource_keys": [], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [], - "name": "grouped_asset_1", + "name": "middle_static_partitioned_asset_2", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3527,128 +3807,37 @@ "__class__": "SolidDefSnap", "config_field_snap": { "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, + "default_provided": true, + "default_value_as_json_str": "{}", "description": null, "is_required": false, "name": "config", - "type_key": "Any" + "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" }, "description": null, "input_def_snaps": [], - "name": "grouped_asset_2", + "name": "multi_asset_with_kinds", "output_def_snaps": [ { "__class__": "OutputDefSnap", - "dagster_type_key": "Any", + "dagster_type_key": "Nothing", "description": null, "is_dynamic": false, "is_required": true, - "name": "result" - } - ], - "required_resource_keys": [], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [], - "name": "grouped_asset_4", - "output_def_snaps": [ + "name": "first_kinds_key" + }, { "__class__": "OutputDefSnap", - "dagster_type_key": "Any", + "dagster_type_key": "Nothing", "description": null, "is_dynamic": false, "is_required": true, - "name": "result" + "name": "second_kinds_key" } ], "required_resource_keys": [], "tags": {} }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": "Asset that hangs forever, used to test in-progress ops.", - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "first_asset" - } - ], - "name": "hanging_asset", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" - } - ], - "required_resource_keys": [ - "hanging_asset_resource" - ], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "my_op" - } - ], - "name": "hanging_op", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" - } - ], - "required_resource_keys": [ - "hanging_asset_resource" - ], - "tags": {} - }, { "__class__": "SolidDefSnap", "config_field_snap": { @@ -3662,36 +3851,7 @@ }, "description": null, "input_def_snaps": [], - "name": "hanging_partition_asset", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" - } - ], - "required_resource_keys": [ - "hanging_asset_resource" - ], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [], - "name": "integers_asset", + "name": "multi_run_backfill_policy_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3717,15 +3877,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "upstream_static_partitioned_asset" - } - ], - "name": "middle_static_partitioned_asset_1", + "input_def_snaps": [], + "name": "multipartitions_1", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3756,10 +3909,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "upstream_static_partitioned_asset" + "name": "multipartitions_1" } ], - "name": "middle_static_partitioned_asset_2", + "name": "multipartitions_2", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3773,41 +3926,6 @@ "required_resource_keys": [], "tags": {} }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": true, - "default_value_as_json_str": "{}", - "description": null, - "is_required": false, - "name": "config", - "type_key": "Shape.da39a3ee5e6b4b0d3255bfef95601890afd80709" - }, - "description": null, - "input_def_snaps": [], - "name": "multi_asset_with_kinds", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "first_kinds_key" - }, - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Nothing", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "second_kinds_key" - } - ], - "required_resource_keys": [], - "tags": {} - }, { "__class__": "SolidDefSnap", "config_field_snap": { @@ -3821,7 +3939,7 @@ }, "description": null, "input_def_snaps": [], - "name": "multi_run_backfill_policy_asset", + "name": "multipartitions_fail", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3848,7 +3966,7 @@ }, "description": null, "input_def_snaps": [], - "name": "multipartitions_1", + "name": "my_op", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3879,64 +3997,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "multipartitions_1" - } - ], - "name": "multipartitions_2", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" - } - ], - "required_resource_keys": [], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [], - "name": "multipartitions_fail", - "output_def_snaps": [ - { - "__class__": "OutputDefSnap", - "dagster_type_key": "Any", - "description": null, - "is_dynamic": false, - "is_required": true, - "name": "result" + "name": "hanging_asset" } ], - "required_resource_keys": [], - "tags": {} - }, - { - "__class__": "SolidDefSnap", - "config_field_snap": { - "__class__": "ConfigFieldSnap", - "default_provided": false, - "default_value_as_json_str": null, - "description": null, - "is_required": false, - "name": "config", - "type_key": "Any" - }, - "description": null, - "input_def_snaps": [], - "name": "my_op", + "name": "never_runs_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3967,10 +4031,10 @@ "__class__": "InputDefSnap", "dagster_type_key": "Any", "description": null, - "name": "hanging_asset" + "name": "hanging_op" } ], - "name": "never_runs_asset", + "name": "never_runs_op", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -3996,15 +4060,8 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [ - { - "__class__": "InputDefSnap", - "dagster_type_key": "Any", - "description": null, - "name": "hanging_op" - } - ], - "name": "never_runs_op", + "input_def_snaps": [], + "name": "no_multipartitions_1", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -4031,7 +4088,7 @@ }, "description": null, "input_def_snaps": [], - "name": "no_multipartitions_1", + "name": "not_included_asset", "output_def_snaps": [ { "__class__": "OutputDefSnap", @@ -4436,7 +4493,14 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "not_included_asset" + } + ], "name": "upstream_static_partitioned_asset", "output_def_snaps": [ { @@ -24337,7 +24401,14 @@ }, { "__class__": "SolidInvocationSnap", - "input_dep_snaps": [], + "input_dep_snaps": [ + { + "__class__": "InputDependencySnap", + "input_name": "not_included_asset", + "is_dynamic_collect": false, + "upstream_output_snaps": [] + } + ], "is_dynamic_mapped": false, "solid_def_name": "upstream_static_partitioned_asset", "solid_name": "upstream_static_partitioned_asset", @@ -24542,7 +24613,14 @@ "type_key": "Any" }, "description": null, - "input_def_snaps": [], + "input_def_snaps": [ + { + "__class__": "InputDefSnap", + "dagster_type_key": "Any", + "description": null, + "name": "not_included_asset" + } + ], "name": "upstream_static_partitioned_asset", "output_def_snaps": [ { @@ -24564,7 +24642,7 @@ ''' # --- # name: test_all_snapshot_ids[137] - '95fba788e86b9b4bb2de437436dbf5be782e1f02' + 'ea8e78a81a6c470713834d21c023ab1d45d00394' # --- # name: test_all_snapshot_ids[138] ''' @@ -34053,7 +34131,7 @@ 'd9f6d85793df3d9df94d4aedb21bb659c1202bda' # --- # name: test_all_snapshot_ids[1] - '6a10762c0be27c5d99bc14d1e1964cc7b60351df' + 'e3c865407ca4b1623f7d29ccbdc56d77a3da497b' # --- # name: test_all_snapshot_ids[20] ''' diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_assets.ambr b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_assets.ambr index e5105cbd84425..6e59d4895372a 100644 --- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_assets.ambr +++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_assets.ambr @@ -405,6 +405,14 @@ ]), }), }), + dict({ + 'id': 'test.test_repo.["not_included_asset"]', + 'key': dict({ + 'path': list([ + 'not_included_asset', + ]), + }), + }), dict({ 'id': 'test.test_repo.["one"]', 'key': dict({ @@ -827,6 +835,11 @@ 'freshnessPolicy': None, 'id': 'test.test_repo.["no_multipartitions_1"]', }), + dict({ + 'freshnessInfo': None, + 'freshnessPolicy': None, + 'id': 'test.test_repo.["not_included_asset"]', + }), dict({ 'freshnessInfo': None, 'freshnessPolicy': None, diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_solids.ambr b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_solids.ambr index 7df38bd9f1bd0..f32dbb64d187d 100644 --- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_solids.ambr +++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_solids.ambr @@ -1755,6 +1755,22 @@ }), ]), }), + dict({ + '__typename': 'UsedSolid', + 'definition': dict({ + 'name': 'not_included_asset', + }), + 'invocations': list([ + dict({ + 'pipeline': dict({ + 'name': '__ASSET_JOB', + }), + 'solidHandle': dict({ + 'handleID': 'not_included_asset', + }), + }), + ]), + }), dict({ '__typename': 'UsedSolid', 'definition': dict({ diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/repo.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/repo.py index 7239d527e10e1..2be626cef1edd 100644 --- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/repo.py +++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/repo.py @@ -1450,8 +1450,12 @@ def executable_asset(unexecutable_asset) -> None: static_partitions_def = StaticPartitionsDefinition(["a", "b", "c", "d", "e", "f"]) +@asset +def not_included_asset(): ... + + @asset(partitions_def=static_partitions_def) -def upstream_static_partitioned_asset(): +def upstream_static_partitioned_asset(not_included_asset): return 1 @@ -2089,6 +2093,7 @@ def define_assets(): upstream_daily_partitioned_asset, downstream_weekly_partitioned_asset, unpartitioned_upstream_of_partitioned, + not_included_asset, upstream_static_partitioned_asset, middle_static_partitioned_asset_1, middle_static_partitioned_asset_2, diff --git a/python_modules/dagster/dagster/_core/execution/asset_backfill.py b/python_modules/dagster/dagster/_core/execution/asset_backfill.py index eb5d715c6608b..7fe3026e41ae8 100644 --- a/python_modules/dagster/dagster/_core/execution/asset_backfill.py +++ b/python_modules/dagster/dagster/_core/execution/asset_backfill.py @@ -335,6 +335,7 @@ def get_targeted_asset_keys_topological_order( item for items_by_level in toposort({node.key: node.parent_keys for node in nodes}) for item in sorted(items_by_level) + if item in self.target_subset.asset_keys ] def get_backfill_status_per_asset_key(