What's the correct way to use AssetCheckSpec with AssetsDefinition.from_graph()?

[zyd14]

I'm running into an error when I try to use AssetCheckSpec with AssetDefinition.from_graph(). When I do

@graph(name="offsets")
def trigger_offsets_generation_graph():
  ...

AssetsDefinition.from_graph(
  trigger_offsets_generation_graph,  # this graph 
  group_name="offsets",
  check_specs=[name="test", asset_key="offsets",
)

I get the following error:

dagster._core.errors.DagsterInvalidDefinitionError: Invalid asset key AssetKey(['custom_was']) in check spec no_nan_FieldName. Must be one of []

It feels like the AssetCheckSpec is trying to resolve assets before they've had a chance to be loaded into Dagster. What's the correct way to use AssetCheckSpec with AssetsDefinition.from_graph()?

For completeness, here's the full stack trace:

dagster._core.errors.DagsterInvalidDefinitionError: Invalid asset key AssetKey(['custom_was']) in check spec no_nan_FieldName. Must be one of []
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_grpc/server.py", line 295, in __init__
    self._loaded_repositories: Optional[LoadedRepositories] = LoadedRepositories(
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_grpc/server.py", line 139, in __init__
    loadable_targets = get_loadable_targets(
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_grpc/utils.py", line 37, in get_loadable_targets
    else loadable_targets_from_python_file(python_file, working_directory)
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/workspace/autodiscovery.py", line 26, in loadable_targets_from_python_file
    loaded_module = load_python_file(python_file, working_directory)
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/code_pointer.py", line 83, in load_python_file
    return import_module_from_path(module_name, python_file)
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_seven/__init__.py", line 48, in import_module_from_path
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "etxlib/etxdagster/repo.py", line 135, in <module>
    from etxlib.etxdagster.pipelines.job_notifications import (
  File "/Users/zach/Documents/empirico/projects/etxlib/etxlib/etxdagster/pipelines/job_notifications.py", line 29, in <module>
    from etxlib.etxdagster.pipelines.offsets_generation import trigger_offsets_generation
  File "/Users/zach/Documents/empirico/projects/etxlib/etxlib/etxdagster/pipelines/offsets_generation/__init__.py", line 1, in <module>
    from .custom_was_pipeline import trigger_offsets_generation
  File "/Users/zach/Documents/empirico/projects/etxlib/etxlib/etxdagster/pipelines/offsets_generation/custom_was_pipeline.py", line 343, in <module>
    AssetsDefinition.from_graph(
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/decorator_utils.py", line 195, in wrapped_with_pre_call_fn
    return fn(*args, **kwargs)
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/definitions/assets.py", line 435, in from_graph
    return AssetsDefinition._from_node(
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/definitions/assets.py", line 599, in _from_node
    check_specs_by_output_name = _validate_and_assign_output_names_to_check_specs(
  File "/Users/zach/Documents/empirico/projects/etxlib/.venvs/hailenv109/lib/python3.9/site-packages/dagster/_core/definitions/decorators/asset_decorator.py", line 1369, in _validate_and_assign_output_names_to_check_specs
    raise DagsterInvalidDefinitionError(

[johannkm]

I can repro, looks like a bug. I've filed #17968 to track

[johannkm]

Fixed in #17969. This should go out in the release this week. Thanks for the report @zyd14!