Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: Add strategy for deployment type. #26445

Closed
acolodreroarion opened this issue Dec 12, 2024 · 0 comments · Fixed by #27048
Closed

Helm Chart: Add strategy for deployment type. #26445

acolodreroarion opened this issue Dec 12, 2024 · 0 comments · Fixed by #27048
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: feature-request

Comments

@acolodreroarion
Copy link

What's the use case?

When deploying a code location server, it should be possible to change paramaters in the helm chart for deployment strategy.

strategy:
replicas: 3
type: RollingUpdate / Recreate / Blue Green
rollingUpdate:
maxUnavailable: 1
maxSurge: 1

Ideas of implementation

Add the code to https://github.com/dagster-io/dagster/blob/master/helm/dagster/charts/dagster-user-deployments/templates/deployment-user.yaml

and add the values to values.yaml

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@garethbrickman garethbrickman added the deployment: k8s Related to deploying Dagster to Kubernetes label Dec 23, 2024
gibsondan pushed a commit that referenced this issue Jan 13, 2025
## Summary & Motivation

Closes: #26445

## How I Tested These Changes

Added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment: k8s Related to deploying Dagster to Kubernetes type: feature-request
Projects
None yet
2 participants