Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] - Add deploymentStrategy to user deployment helm chart #26716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[helm] - Add deploymentStrategy to user deployment helm chart #26716

wants to merge 1 commit into from
+100 −1

Conversation

marijncv
Copy link
Contributor

Summary & Motivation

Closes #26445

How I Tested These Changes

Added a test and ran helm template on a values file like:

deployments:
  - name: "k8s-example-user-code-1"
    image:
      repository: "docker.io/dagster/user-code-example"
      tag: ~
      pullPolicy: Always
    dagsterApiGrpcArgs:
      - "-f"
      - "/example_project/example_repo/repo.py"
    port: 3030
    deploymentStrategy:
      type: Recreate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart: Add strategy for deployment type.
1 participant
@marijncv