Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for dbt-core 1.9.x for dagster-dbt #26538

Open
kang8 opened this issue Dec 17, 2024 · 2 comments · Fixed by #26564
Open

Allow for dbt-core 1.9.x for dagster-dbt #26538

kang8 opened this issue Dec 17, 2024 · 2 comments · Fixed by #26564
Labels

Comments

@kang8
Copy link

kang8 commented Dec 17, 2024

What's the use case?

Last week, dbt-core released v1.9.0. Today I tried to upgrade dbt-core to the 1.9.0 in my project, but I encountered this problem:

 uv add "dbt-core==1.9.0"
  × No solution found when resolving dependencies:
  ╰─▶ Because dagster-dbt==0.25.5 depends on dbt-core>=1.7,<1.9 and your project depends on
      dagster-dbt==0.25.5, we can conclude that your project depends on dbt-core>=1.7,<1.9.
      And because your project depends on dbt-core==1.9.0, we can conclude that your project's requirements
      are unsatisfiable.

So it looks like we just need to allow the 1.9.x version in dagster-dbt.

Ideas of implementation

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@garethbrickman garethbrickman added the integration: dbt Related to dagster-dbt label Dec 18, 2024
OwenKephart pushed a commit that referenced this issue Dec 18, 2024
## Summary & Motivation

Closes #26538

## How I Tested These Changes

I ran the tests in `dagster-dbt` on my local machine. Some tests failed
but that seems due to missing environment variables to test against
remote warehouses.

I'm not sure how to otherwise test this change best. Input would be
appreciated!

## Changelog

[dagster-dbt] `dbt-core>=1.9` is now supported
@stiabh
Copy link

stiabh commented Dec 20, 2024

Has this issue really been resolved? I tried to install both dagster_dbt 0.25.6 and dbt-core 1.9.1, but pip still returns a conflicting dependency error. Running pip without version numbers, i.e pip install dbt-core dbt_dagster results in dbt-core version 1.8.9 and dbt_dagster version 0.25.6.

@OwenKephart
Copy link
Contributor

Hi @stiabh -- the fix has been merged in, but a release has not yet gone out with the fix applied (github auto-closes issues on merge, sorry for the confusion!). I'll reopen this issue until the next release goes out.

@OwenKephart OwenKephart reopened this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants