Update dagster_sdf to be compatible with recent SDF versions (0.3.23 -> 0.10.8)
#26665
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlarose
reviewed
Dec 26, 2024
There was a problem hiding this comment.
Hi @elliottower, thanks for the contribution.
What are the reasons to keep such a narrow gap and force the upgrade for users with older SDF?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The current SDF version is 0.10.8, but the
dagster_sdfpackage requires a significantly older version 0.3.23.How I Tested These Changes
I modified the library locally on my machine and ran the official dagster sdf tutorial from the SDF docs (link)
Following this tutorial with the older version worked as well, but limited ability to do advanced SDF features (e.g., BigQuery integration). The documentation is also quite different from so many version changes, so it was hard to figure out the issue.
Changelog