Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DagsterSlingTranslator.sanitize_stream_name() forces asset names to be lowercase #26673

Open
Cogito opened this issue Dec 23, 2024 · 0 comments
Labels
integration: embedded-elt Related to dagster-embedded-elt which uses Sling and data Load Tool (dlt)

Comments

@Cogito
Copy link

Cogito commented Dec 23, 2024

Thanks to this check

if self.sanitize_stream_name(asset_key) != asset_key:

any asset keys provided in the sling replication as meta information are forced to be lowercase, as per this code

return re.sub(r"[^a-zA-Z0-9_.]", "_", stream_name.replace('"', "").lower())

I'm aware that this can be replaced with a custom SlingTranslator, but wondering if this should be the default?

@garethbrickman garethbrickman added the integration: embedded-elt Related to dagster-embedded-elt which uses Sling and data Load Tool (dlt) label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: embedded-elt Related to dagster-embedded-elt which uses Sling and data Load Tool (dlt)
Projects
None yet
Development

No branches or pull requests

2 participants