Refactor UnboundOpExecutionContext.bind to use contextmanager #15990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 21, 2023
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
from
5101150 to
47aa075
Compare
This was referenced Aug 21, 2023
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
2 times, most recently
from
410c461 to
7efef15
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4f9a917. |
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
from
7efef15 to
cb8062b
Compare
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
from
cb8062b to
8bc7365
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 4f9a917. |
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
2 times, most recently
from
1de6541 to
de8a156
Compare
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
2 times, most recently
from
8bf6075 to
d03c862
Compare
schrockn
force-pushed
the
clean-up-dual-state-context-1
branch
from
d03c862 to
4f9a917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
UnboundOpExecutionContext.bind current uses the exit stack to manage contextful resources created for a single call. This unnecessarly couples it to that instance. Instead we can just use the native contextmanager facility, which ends up being more composable.
How I Tested These Changes
BK