Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpExecutionContext metaclass #16486

Closed
wants to merge 1 commit into from
Closed

OpExecutionContext metaclass #16486

wants to merge 1 commit into from

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Sep 13, 2023 •
edited
Loading

Summary & Motivation

Adds a metaclass for OpExecutionContext so that AssetExecutionContext is considered a OpExecutionContext for internal type checks

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Sep 13, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Sep 13, 2023
Closed
Closed
@jamiedemaria jamiedemaria changed the title Simplified AssetExecutionContext OpExecutionContext metaclass Sep 13, 2023
@jamiedemaria jamiedemaria mentioned this pull request Sep 13, 2023
Closed
@jamiedemaria jamiedemaria marked this pull request as ready for review September 14, 2023 13:46
@jamiedemaria jamiedemaria requested review from schrockn, clairelin135, smackesey and alangenfeld and removed request for clairelin135 September 14, 2023 13:56
@jamiedemaria jamiedemaria mentioned this pull request Sep 14, 2023
Merged
@jamiedemaria jamiedemaria force-pushed the jamie/context-interface branch from 9508725 to 59fd5df Compare September 18, 2023 15:06
@jamiedemaria jamiedemaria force-pushed the jamie/op-context-metaclass branch from 0ed2a54 to 9e2cf21 Compare September 18, 2023 15:06
This was referenced Sep 18, 2023
Closed
Closed
@jamiedemaria
Copy link
Contributor Author

closing as we're going down the subclass route. Can re-open if needed

This was referenced Sep 19, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrockn schrockn Awaiting requested review from schrockn

@smackesey smackesey Awaiting requested review from smackesey

@alangenfeld alangenfeld Awaiting requested review from alangenfeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamiedemaria