[docs] [essentials] - Dagster UI #16526
Conversation
- Move Asset section up - Update screenshots - Add Global Asset Lineage page
wtf github?
|
@jamiedemaria I wound up doing an overhaul of this, since it was absurdly out of date and incomplete. I left a list of stuff I changed in the PR description, along with preview links to those changes - that should make it easier to review. I didn't go for exhaustive, but instead obvious and/or painful gaps that needed to be filled. |
There was a problem hiding this comment.
this is beautiful! I really like it. A couple things:
- I think getting Josh's feedback would be good - he might have ideas of specific features to point out on some pages, or other flows through the UI that are worth discussing
- I might be weird in this, but my primary way of navigating around the UI is by using the side nav. I don't think the page is lacking because it doesn't talk about the side nav, but it could be worth mentioning. It'd be worth double checking what the status of the "kill the sidenav" project is before investing time writing anything about it.
- how time consuming would it be to put boxes around the "how to get there" buttons in the screenshots to make them jump out even more? if it's more than like 10min of work, or if it's something that would have to get manually redone all the time, then i dont think it's worth it. but if it's easy it'd be nice to really highlight the tab in question
|
|
||
| Click a schedule to view details about the schedule, including its recent tick history and recent runs. | ||
| - **Accessed by:** Clicking the **Overview** tab in the [**Job details**](#job-details) page |
There was a problem hiding this comment.
is there a slightly different way we could explain this? when i first read it i thought it was referring to the top nav Overview tab.
There was a problem hiding this comment.
What about In the **Job details** page, click the **Overview** tab?
| base_url: https://demo.elementl.show | ||
| route: /instance/assets | ||
| vetted: false | ||
| # - id: all-assets.png |
There was a problem hiding this comment.
remove commented entry before merge
Co-authored-by: jamiedemaria <[email protected]>
…er-io/dagster into erin/essentials-dagster-ui
|
Back to you @jamiedemaria!
Asked him about this earlier! He's happy with these changes and didn't have any additions at this time.
I think doing this in a follow-up PR would be good - I want to make sure this gets out in time for launch week, and there's still a lot to get through 😅
Right now this would be all manually done and would have to be re-done every time we update the screenshots. -_-; I get what you mean though. |
|
Thanks for your help on this monster PR, y'all! Off it goes 🚀 |
Summary & Motivation
This PR (unintentionally) refactors the Dagster UI concept page. This was pretty out of date and incomplete, so I took the opportunity to spiff it up. Specifically, it:
How I Tested These Changes
👀 , local