-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docblock for SensorResult.asset_events #16705
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
49523de
to
a9acf3b
Compare
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit a9acf3b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content looks good. left a suggestion in terms of formatting
python_modules/dagster/dagster/_core/definitions/run_request.py
Outdated
Show resolved
Hide resolved
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit a9acf3b. |
Co-authored-by: Yuhan Luo <[email protected]>
Summary & Motivation
Since we are putting an experimental param on a publicly exporting class, we should document it.
How I Tested These Changes
BK