Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docblock for SensorResult.asset_events #16705

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

schrockn
Copy link
Member

Summary & Motivation

Since we are putting an experimental param on a publicly exporting class, we should document it.

How I Tested These Changes

BK

@schrockn
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@schrockn schrockn force-pushed the document-sensor-result branch from 49523de to a9acf3b Compare September 26, 2023 13:09
@schrockn schrockn requested review from sryza and yuhan September 26, 2023 13:10
@schrockn schrockn marked this pull request as ready for review September 26, 2023 13:10
@github-actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-16l6y6mft-elementl.vercel.app
https://document-sensor-result.core-storybook.dagster-docs.io

Built with commit a9acf3b.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks good. left a suggestion in terms of formatting

@github-actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-ovy0off7z-elementl.vercel.app
https://document-sensor-result.components-storybook.dagster-docs.io

Built with commit a9acf3b.
This pull request is being automatically deployed with vercel-action

@schrockn schrockn merged commit ad95c8a into master Sep 26, 2023
1 check failed
@schrockn schrockn deleted the document-sensor-result branch September 26, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants