From 95068beea485fb992427996d5e685a4baf3b4661 Mon Sep 17 00:00:00 2001 From: alangenfeld Date: Thu, 13 Jun 2024 14:31:14 -0500 Subject: [PATCH] [ui] show applyLimitPerUniqueValue entries in queue criteria --- .../ui-core/src/runs/QueuedRunCriteriaDialog.tsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/QueuedRunCriteriaDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/QueuedRunCriteriaDialog.tsx index 35ba9d58a4f46..ccb10e5ac0279 100644 --- a/js_modules/dagster-ui/packages/ui-core/src/runs/QueuedRunCriteriaDialog.tsx +++ b/js_modules/dagster-ui/packages/ui-core/src/runs/QueuedRunCriteriaDialog.tsx @@ -11,6 +11,7 @@ import { Tag, Tooltip, } from '@dagster-io/ui-components'; +import isPlainObject from 'lodash/isPlainObject'; import * as React from 'react'; import {Link} from 'react-router-dom'; import * as yaml from 'yaml'; @@ -66,7 +67,10 @@ const QueuedRunCriteriaDialogContent = ({run}: {run: RunTableRunFragment}) => { return limits.filter( (limit) => limit.key in runTagMap && - (limit.value === undefined || limit.value === runTagMap[limit.key]), + (limit.value === undefined || + limit.value === runTagMap[limit.key] || + // can be {"applyLimitPerUniqueValue": bool} + isPlainObject(limit.value)), ); } catch (err) { return undefined; @@ -119,7 +123,9 @@ const QueuedRunCriteriaDialogContent = ({run}: {run: RunTableRunFragment}) => { - {limit.value !== undefined ? `${limit.key}=${limit.value}` : limit.key} + {limit.value !== undefined + ? `${limit.key}=${JSON.stringify(limit.value)}` // might be obj so stringify + : limit.key}