Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/n][dagster-powerbi] build initial PowerBIWorkspace resource #23246

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Jul 25, 2024

Summary

Adds a PowerBIWorkspace resource, with utility methods to reach out to the PowerBI API.

Test Plan

Mocked out API unit test.

@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from c3e8ba3 to 45d8a2a Compare July 25, 2024 21:47
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 77be152 to 8307af9 Compare July 25, 2024 22:23
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 45d8a2a to 1898ddc Compare July 25, 2024 22:23
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 8307af9 to 5785f61 Compare July 30, 2024 16:21
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 1898ddc to 6ce8805 Compare July 30, 2024 16:21
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 5785f61 to 150a6d4 Compare July 30, 2024 16:32
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 6ce8805 to 58ece8e Compare July 30, 2024 16:32
@benpankow benpankow marked this pull request as ready for review July 30, 2024 16:33
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 150a6d4 to a87df50 Compare July 30, 2024 16:38
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 58ece8e to 9f6e3b8 Compare July 30, 2024 16:39
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from a87df50 to 62e8811 Compare July 30, 2024 19:00
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 9f6e3b8 to fcb4e01 Compare July 30, 2024 19:00
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 62e8811 to 4b3305a Compare August 1, 2024 20:37
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from fcb4e01 to 6f12b5d Compare August 1, 2024 20:37
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 4b3305a to ac17f7d Compare August 1, 2024 21:04
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 6f12b5d to 0e16f87 Compare August 1, 2024 21:04
@@ -0,0 +1,67 @@
from typing import Any, Dict

import requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should use httpx, since it gives us the capability for async requests if we need it https://www.python-httpx.org/#features

@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from ac17f7d to b6db36e Compare August 7, 2024 17:14
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 0e16f87 to 09e0879 Compare August 7, 2024 17:14
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from b6db36e to cd5457e Compare August 7, 2024 17:15
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 09e0879 to 431815d Compare August 7, 2024 17:15
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from cd5457e to f6d4b64 Compare August 7, 2024 20:11
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 431815d to 2473db4 Compare August 7, 2024 20:11
@benpankow benpankow changed the title [3/n][dagster-powerbi] build initial PowerBIResource [3/n][dagster-powerbi] build initial PowerBIWorkspace resource Aug 7, 2024
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from f6d4b64 to 9ad8525 Compare August 7, 2024 20:28
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 2473db4 to b7580d0 Compare August 7, 2024 20:28
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 9ad8525 to 778448d Compare August 12, 2024 17:50
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from b7580d0 to e72ba04 Compare August 12, 2024 17:50
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-next ❌ Failed (Inspect) Aug 12, 2024 5:50pm

@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from 778448d to c075164 Compare August 13, 2024 12:30
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from e72ba04 to 49dc082 Compare August 13, 2024 12:30
@benpankow benpankow force-pushed the benpankow/add-powerbi-2 branch from c075164 to 8c3861c Compare August 30, 2024 14:43
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch 2 times, most recently from 49fb988 to 051d53f Compare August 30, 2024 16:47
Base automatically changed from benpankow/add-powerbi-2 to master August 30, 2024 17:57
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 051d53f to 5e188f2 Compare August 30, 2024 18:00
@benpankow benpankow force-pushed the benpankow/add-powerbi-3 branch from 5e188f2 to 2240fc3 Compare August 30, 2024 18:25
@benpankow
Copy link
Member Author

benpankow commented Aug 30, 2024

Merge activity

  • Aug 30, 11:25 AM PDT: Graphite rebased this pull request as part of a merge.
  • Aug 30, 11:27 AM PDT: @benpankow merged this pull request with Graphite.

@benpankow benpankow merged commit 099b77a into master Aug 30, 2024
1 check was pending
@benpankow benpankow deleted the benpankow/add-powerbi-3 branch August 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants