Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7/n][dagster-powerbi] publish dagster-powerbi, add apidoc #23339

Closed
wants to merge 4 commits into from
Closed

[7/n][dagster-powerbi] publish dagster-powerbi, add apidoc #23339

wants to merge 4 commits into from

Conversation

benpankow
Copy link
Member

Summary

Publish dagster-powerbi package, and add apidocs

@graphite-app graphite-app bot requested a review from erinkcochran87 July 30, 2024 18:58
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jul 30, 2024
This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
@benpankow
Copy link
Member Author

benpankow commented Jul 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@benpankow benpankow mentioned this pull request Jul 30, 2024
Merged
@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from 7f792ed to 0ef544f Compare July 30, 2024 19:01
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from c0f7645 to 24fd701 Compare July 30, 2024 19:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-f421h4era-elementl.vercel.app
https://benpankow-add-powerbi-6.dagster.dagster-docs.io

Direct link to changed pages:

@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from 0ef544f to e964aed Compare August 1, 2024 20:37
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 24fd701 to e43a248 Compare August 1, 2024 20:37
@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from e964aed to 63ea599 Compare August 1, 2024 21:04
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from e43a248 to 3482447 Compare August 1, 2024 21:04
erinkcochran87
erinkcochran87 reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a few small changes:

  1. Add to the sidenav under API reference > Libraries
  2. The missing JSON files created by running make apidoc-build

Could you make these changes and then send this back over?

@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from 63ea599 to cd2772e Compare August 7, 2024 17:15
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 3482447 to 40fd7d3 Compare August 7, 2024 17:15
@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from cd2772e to f715089 Compare August 7, 2024 17:15
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 40fd7d3 to d5d6084 Compare August 7, 2024 17:15
@benpankow benpankow mentioned this pull request Aug 7, 2024
Closed
@benpankow benpankow force-pushed the benpankow/add-powerbi-5 branch from f715089 to dff70fc Compare August 7, 2024 20:11
@benpankow benpankow mentioned this pull request Aug 7, 2024
Closed
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from d5d6084 to 7b5e7c1 Compare August 7, 2024 20:11
@benpankow benpankow changed the base branch from benpankow/add-powerbi-5 to benpankow/add-powerbi-caching August 7, 2024 20:11
@benpankow benpankow mentioned this pull request Aug 7, 2024
Merged
@benpankow benpankow changed the title [6/n][dagster-powerbi] publish dagster-powerbi, add apidoc [7/n][dagster-powerbi] publish dagster-powerbi, add apidoc Aug 7, 2024
@benpankow benpankow marked this pull request as draft August 7, 2024 20:13
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 7b5e7c1 to b1aa8ed Compare August 7, 2024 20:25
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from e4a5db8 to afa86ae Compare August 7, 2024 20:28
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from b1aa8ed to 4ea19c8 Compare August 7, 2024 20:28
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from afa86ae to a8b1aa8 Compare August 12, 2024 17:50
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 4ea19c8 to 4b55ace Compare August 12, 2024 17:50
@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-next ❌ Failed (Inspect) Aug 12, 2024 5:51pm

@benpankow benpankow mentioned this pull request Aug 12, 2024
Merged
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from a8b1aa8 to 1a68506 Compare August 13, 2024 12:30
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 4b55ace to 6da387b Compare August 13, 2024 12:30
sryza
sryza suggested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should publish the package but hold off on publishing API doc until we feel more confident about the APIs

@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from 1a68506 to 4cb9518 Compare August 30, 2024 14:43
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from 6da387b to fb731f5 Compare August 30, 2024 14:43
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from 4cb9518 to 8b54a7a Compare August 30, 2024 16:48
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from fb731f5 to caa5859 Compare August 30, 2024 16:48
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from 8b54a7a to d9d5c7b Compare August 30, 2024 18:01
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from caa5859 to d5d070d Compare August 30, 2024 18:01
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from d9d5c7b to 84484b9 Compare August 30, 2024 18:28
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from d5d070d to cd5e751 Compare August 30, 2024 18:29
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from 84484b9 to 0ef8ebf Compare August 30, 2024 18:56
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from cd5e751 to b0089a1 Compare August 30, 2024 18:57
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from 0ef8ebf to d646eab Compare August 30, 2024 19:00
@benpankow benpankow force-pushed the benpankow/add-powerbi-6 branch from b0089a1 to 05f56e0 Compare August 30, 2024 19:00
@benpankow benpankow force-pushed the benpankow/add-powerbi-caching branch from d646eab to de2eaab Compare August 30, 2024 19:58
Base automatically changed from benpankow/add-powerbi-caching to master August 30, 2024 21:23
@benpankow benpankow mentioned this pull request Aug 30, 2024
Closed
@benpankow benpankow closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinkcochran87 erinkcochran87 erinkcochran87 left review comments

@sryza sryza sryza requested changes

@neverett neverett Awaiting requested review from neverett neverett will be requested when the pull request is marked ready for review neverett is a code owner

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpankow @sryza @erinkcochran87