Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify steps exempt for Serverless deployment in CLI branch deployment #23430

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

garethbrickman
Copy link
Contributor

@garethbrickman garethbrickman commented Aug 5, 2024

Summary & Motivation

Doc: Using Branch Deployments (CI) with the dagster-cloud CLI

Doc is Hybrid-centric so Serverless deployment users can be confused in some steps

How I Tested These Changes

👀

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-plndmxic4-elementl.vercel.app
https://gary-docs-cli-branch-deployment.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you still need the agent token from step 1 (or a user token) in step 3

@garethbrickman garethbrickman merged commit 3012a29 into master Aug 13, 2024
1 of 2 checks passed
@garethbrickman garethbrickman deleted the gary/docs-cli-branch-deployment branch August 13, 2024 13:40
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
…eployment (#23430)

## Summary & Motivation
Doc: [Using Branch Deployments (CI) with the dagster-cloud
CLI](https://docs.dagster.io/dagster-plus/managing-deployments/branch-deployments/using-branch-deployments#using-branch-deployments-ci-with-the-dagster-cloud-cli
)

Doc is Hybrid-centric so Serverless deployment users can be confused in
some steps

## How I Tested These Changes
👀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants