[sling] remove deprecations #23461
Merged
[sling] remove deprecations #23461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmpadden
force-pushed
the
colton/rm-sling-deprecations
branch
from
3aebd4b to
6021602
Compare
cmpadden
requested review from
PedramNavid and
rexledesma
and removed request for
erinkcochran87
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-mgjzrxv0u-elementl.vercel.app Direct link to changed pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Removes deprecated methods and classes indicated as breaking in v0.23.0.
build_sling_assetSlingSourceConnectionSlingTargetConnectionsyncI migrated unit tests that used
SlingSourceConnectionandSlingTargetConnectiontoSlingConnection.However, I removed the
build_sling_assettests altogether. Let me know if you would prefer to convert these to the decorator approach.How I Tested These Changes
tox