[6/n][dagster-powerbi] use asset caching logic for powerbi assets #23486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
benpankow
changed the title
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
dff70fc to
dbb53b4
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
e4a5db8 to
afa86ae
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
dbb53b4 to
6ec9f88
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
afa86ae to
a8b1aa8
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
6ec9f88 to
5fd1cff
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
a8b1aa8 to
1a68506
Compare
sryza
approved these changes
Aug 28, 2024
| using the provided translator. | ||
| Future work will cache this data to avoid repeated calls to the Power BI API. | ||
| ) -> Sequence[CacheableAssetsDefinition]: | ||
| """Returns a set of CacheableAssetsDefinition which will load Power BI content from |
There was a problem hiding this comment.
Suggested change
| """Returns a set of CacheableAssetsDefinition which will load Power BI content from | |
| """Returns a set of CacheableAssetsDefinitions which will load Power BI content from |
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
5fd1cff to
74baef1
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
1a68506 to
4cb9518
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
74baef1 to
484a875
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
4cb9518 to
8b54a7a
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
484a875 to
e818bf9
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
8b54a7a to
d9d5c7b
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
from
e818bf9 to
3e7a8be
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
d9d5c7b to
84484b9
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-5
branch
2 times, most recently
from
04a462f to
6444cf1
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
84484b9 to
0ef8ebf
Compare
benpankow
changed the base branch from
benpankow/add-powerbi-5
to
graphite-base/23486
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
0ef8ebf to
d646eab
Compare
benpankow
force-pushed
the
graphite-base/23486
branch
from
6444cf1 to
15611dc
Compare
benpankow
force-pushed
the
benpankow/add-powerbi-caching
branch
from
d646eab to
de2eaab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In response to feedback on asset caching apis in #23341, uses cacheable assets definitions to ensure that PowerBI data is only fetched from the API once. Once we settle on more agreeable asset caching apis, we can improve the ergonomics here.
Test Plan
New unit test to load a repo and launch runs without re-fetching data from PowerBI APIs.