-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all_deps_blocking_checks_passed
condition
#25171
Merged
OwenKephart
merged 1 commit into
master
from
10-09-add_all_deps_blocking_checks_passed_condition
Oct 15, 2024
Merged
Add all_deps_blocking_checks_passed
condition
#25171
OwenKephart
merged 1 commit into
master
from
10-09-add_all_deps_blocking_checks_passed_condition
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 10, 2024 16:18
8419f02
to
da39e59
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 10, 2024 16:19
1b23dfa
to
f8d9617
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 10, 2024 17:30
da39e59
to
d7ab501
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 10, 2024 17:30
f8d9617
to
4deb33e
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 10, 2024 19:39
d7ab501
to
f40a7c4
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 10, 2024 19:39
4deb33e
to
7010afc
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 11, 2024 00:29
f40a7c4
to
aa4cfb6
Compare
This was referenced Oct 11, 2024
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 11, 2024 00:29
7010afc
to
3cb2753
Compare
This was referenced Oct 11, 2024
schrockn
reviewed
Oct 11, 2024
python_modules/dagster/dagster/_core/definitions/declarative_automation/automation_condition.py
Outdated
Show resolved
Hide resolved
schrockn
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expand on what is going on here in docblock.
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 11, 2024 17:17
aa4cfb6
to
e5a93e4
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 11, 2024 17:17
3cb2753
to
6956152
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 11, 2024 19:45
e5a93e4
to
647900f
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 11, 2024 19:45
6956152
to
5edfb96
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 11, 2024 22:24
647900f
to
a3dc42a
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 11, 2024 22:25
5edfb96
to
83506d8
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 14, 2024 16:51
a3dc42a
to
928e655
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 14, 2024 16:51
83506d8
to
177125c
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 14, 2024 17:03
928e655
to
de2b9d0
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 14, 2024 17:03
177125c
to
cad8dd2
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 15, 2024 17:31
de2b9d0
to
037c715
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 15, 2024 17:32
cad8dd2
to
f8c1d2c
Compare
OwenKephart
force-pushed
the
10-09-make_existing_conditions_work_with_asset_checks
branch
from
October 15, 2024 17:54
037c715
to
85f4d3e
Compare
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 15, 2024 17:54
f8c1d2c
to
bd71cf4
Compare
Base automatically changed from
10-09-make_existing_conditions_work_with_asset_checks
to
master
October 15, 2024 18:48
OwenKephart
force-pushed
the
10-09-add_all_deps_blocking_checks_passed_condition
branch
from
October 15, 2024 18:49
bd71cf4
to
19e3e9e
Compare
OwenKephart
deleted the
10-09-add_all_deps_blocking_checks_passed_condition
branch
October 15, 2024 18:50
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title
How I Tested These Changes
Changelog