Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all_deps_blocking_checks_passed condition #25171

Merged

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

As title

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from 8419f02 to da39e59 Compare October 10, 2024 16:18
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 1b23dfa to f8d9617 Compare October 10, 2024 16:19
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from da39e59 to d7ab501 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from f8d9617 to 4deb33e Compare October 10, 2024 17:30
@OwenKephart OwenKephart requested a review from schrockn October 10, 2024 17:39
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from d7ab501 to f40a7c4 Compare October 10, 2024 19:39
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 4deb33e to 7010afc Compare October 10, 2024 19:39
@OwenKephart OwenKephart marked this pull request as ready for review October 10, 2024 20:38
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from f40a7c4 to aa4cfb6 Compare October 11, 2024 00:29
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 7010afc to 3cb2753 Compare October 11, 2024 00:29
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expand on what is going on here in docblock.

@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from aa4cfb6 to e5a93e4 Compare October 11, 2024 17:17
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 3cb2753 to 6956152 Compare October 11, 2024 17:17
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from e5a93e4 to 647900f Compare October 11, 2024 19:45
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 6956152 to 5edfb96 Compare October 11, 2024 19:45
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from 647900f to a3dc42a Compare October 11, 2024 22:24
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 5edfb96 to 83506d8 Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from a3dc42a to 928e655 Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 83506d8 to 177125c Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from 928e655 to de2b9d0 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from 177125c to cad8dd2 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from de2b9d0 to 037c715 Compare October 15, 2024 17:31
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from cad8dd2 to f8c1d2c Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-09-make_existing_conditions_work_with_asset_checks branch from 037c715 to 85f4d3e Compare October 15, 2024 17:54
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from f8c1d2c to bd71cf4 Compare October 15, 2024 17:54
Copy link
Contributor Author

OwenKephart commented Oct 15, 2024

Merge activity

  • Oct 15, 2:48 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 2:49 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 2:50 PM EDT: A user merged this pull request with Graphite.

Base automatically changed from 10-09-make_existing_conditions_work_with_asset_checks to master October 15, 2024 18:48
@OwenKephart OwenKephart force-pushed the 10-09-add_all_deps_blocking_checks_passed_condition branch from bd71cf4 to 19e3e9e Compare October 15, 2024 18:49
@OwenKephart OwenKephart merged commit f724ea8 into master Oct 15, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-09-add_all_deps_blocking_checks_passed_condition branch October 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants