Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move all operands into a single file #25187

Merged

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

Minor refactor -- these implementations are all very simple and it's easier mentally to have them in a single place. Bumped the SubsetAutomationCondition into its own file as it cannot be directly instantiated.

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @OwenKephart and the rest of your teammates on Graphite Graphite

@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from aced9dd to 1357a85 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 311c3b8 to 66311c6 Compare October 10, 2024 17:30
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1357a85 to 4491ce3 Compare October 10, 2024 19:40
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 66311c6 to 1f03a21 Compare October 10, 2024 19:40
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 4491ce3 to 1efdac9 Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 1f03a21 to 59c7c45 Compare October 11, 2024 00:30
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1efdac9 to 791df56 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 59c7c45 to ee98440 Compare October 11, 2024 17:18
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 791df56 to 904d371 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from ee98440 to 28ef6c8 Compare October 11, 2024 19:46
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 904d371 to 0f16ffb Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 28ef6c8 to 9d0fd47 Compare October 11, 2024 22:25
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 0f16ffb to f463f7f Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 9d0fd47 to 963f91e Compare October 14, 2024 16:51
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from f463f7f to 776c557 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 963f91e to e3cc307 Compare October 14, 2024 17:03
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 776c557 to 1dfdb5d Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from e3cc307 to dface2b Compare October 15, 2024 17:32
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 1dfdb5d to e72ffda Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from dface2b to 1973124 Compare October 15, 2024 17:55
@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from e72ffda to 5d9eb60 Compare October 15, 2024 18:51
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 1973124 to 00cd59a Compare October 15, 2024 18:52
Copy link
Contributor Author

OwenKephart commented Oct 15, 2024

Merge activity

  • Oct 15, 3:52 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 15, 3:57 PM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 15, 3:58 PM EDT: A user merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 10-10-remove_description_property_make_names_more_descriptive branch from 5d9eb60 to 0628cc4 Compare October 15, 2024 19:54
Base automatically changed from 10-10-remove_description_property_make_names_more_descriptive to master October 15, 2024 19:56
@OwenKephart OwenKephart force-pushed the 10-10-_refactor_move_all_operands_into_a_single_file branch from 00cd59a to e559825 Compare October 15, 2024 19:56
@OwenKephart OwenKephart merged commit f1468de into master Oct 15, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 10-10-_refactor_move_all_operands_into_a_single_file branch October 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants