-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Move all operands into a single file #25187
Merged
OwenKephart
merged 1 commit into
master
from
10-10-_refactor_move_all_operands_into_a_single_file
Oct 15, 2024
Merged
[refactor] Move all operands into a single file #25187
OwenKephart
merged 1 commit into
master
from
10-10-_refactor_move_all_operands_into_a_single_file
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 10, 2024 17:30
aced9dd
to
1357a85
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 10, 2024 17:30
311c3b8
to
66311c6
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 10, 2024 19:40
1357a85
to
4491ce3
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 10, 2024 19:40
66311c6
to
1f03a21
Compare
This was referenced Oct 10, 2024
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 00:30
4491ce3
to
1efdac9
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 00:30
1f03a21
to
59c7c45
Compare
This was referenced Oct 11, 2024
schrockn
approved these changes
Oct 11, 2024
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 17:18
1efdac9
to
791df56
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 17:18
59c7c45
to
ee98440
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 19:46
791df56
to
904d371
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 19:46
ee98440
to
28ef6c8
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 11, 2024 22:25
904d371
to
0f16ffb
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 11, 2024 22:25
28ef6c8
to
9d0fd47
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 14, 2024 16:51
0f16ffb
to
f463f7f
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 14, 2024 16:51
9d0fd47
to
963f91e
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 14, 2024 17:03
f463f7f
to
776c557
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 14, 2024 17:03
963f91e
to
e3cc307
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 17:32
776c557
to
1dfdb5d
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 17:32
e3cc307
to
dface2b
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 17:55
1dfdb5d
to
e72ffda
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 17:55
dface2b
to
1973124
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 18:51
e72ffda
to
5d9eb60
Compare
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 18:52
1973124
to
00cd59a
Compare
OwenKephart
force-pushed
the
10-10-remove_description_property_make_names_more_descriptive
branch
from
October 15, 2024 19:54
5d9eb60
to
0628cc4
Compare
Base automatically changed from
10-10-remove_description_property_make_names_more_descriptive
to
master
October 15, 2024 19:56
OwenKephart
force-pushed
the
10-10-_refactor_move_all_operands_into_a_single_file
branch
from
October 15, 2024 19:56
00cd59a
to
e559825
Compare
OwenKephart
deleted the
10-10-_refactor_move_all_operands_into_a_single_file
branch
October 15, 2024 19:58
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Minor refactor -- these implementations are all very simple and it's easier mentally to have them in a single place. Bumped the SubsetAutomationCondition into its own file as it cannot be directly instantiated.
How I Tested These Changes
Changelog
NOCHANGELOG