From 7e82f38eda64c90140182920342efbbb91bf6a51 Mon Sep 17 00:00:00 2001
From: David Liu <d.liu@dagsterlabs.com>
Date: Tue, 3 Dec 2024 11:17:17 -0500
Subject: [PATCH 1/4] add jest tests

---
 .../ui-core/src/ticks/DryRunRequestTable.tsx  |  9 ++++-
 .../__tests__/DryRunRequestTable.test.tsx     | 21 ++++++++--
 .../__tests__/EvaluateScheduleDialog.test.tsx | 38 +++++++++++++++++++
 .../__tests__/SensorDryRunDialog.test.tsx     | 30 +++++++++++++--
 4 files changed, 88 insertions(+), 10 deletions(-)

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx
index ca8082e8561fb..b9859d06be68a 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/DryRunRequestTable.tsx
@@ -52,6 +52,7 @@ export const RunRequestTable = ({runRequests, isJob, repoAddress, mode, jobName}
             </td>
             <td style={{width: '7.5%', verticalAlign: 'middle', textAlign: 'center'}}>
               <PreviewButton
+                request={request}
                 onClick={() => {
                   setSelectedRequest(request);
                   setVisibleDialog('config');
@@ -91,10 +92,14 @@ export const RunRequestTable = ({runRequests, isJob, repoAddress, mode, jobName}
   );
 };
 
-function PreviewButton({onClick}: {onClick: () => void}) {
+function PreviewButton({request, onClick}: {request: RunRequestFragment; onClick: () => void}) {
   return (
     <Tooltip content="Preview run config and tags" placement="left-start">
-      <Button icon={<Icon name="data_object" />} onClick={onClick} />
+      <Button
+        icon={<Icon name="data_object" />}
+        onClick={onClick}
+        data-testid={testId(`preview-${request.runKey || ''}`)}
+      />
     </Tooltip>
   );
 }
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/DryRunRequestTable.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/DryRunRequestTable.test.tsx
index f8f2a760ec648..a1985435b0db5 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/DryRunRequestTable.test.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/DryRunRequestTable.test.tsx
@@ -1,4 +1,4 @@
-import {render, screen} from '@testing-library/react';
+import {render, screen, waitFor} from '@testing-library/react';
 import {BrowserRouter} from 'react-router-dom';
 
 import {RunRequestTable} from '../DryRunRequestTable';
@@ -9,6 +9,10 @@ jest.mock('../../workspace/WorkspaceContext/util', () => ({
   useRepository: jest.fn(() => null),
 }));
 
+jest.mock('../../runs/RunConfigDialog', () => ({
+  RunConfigDialog: () => <div>RunConfigDialog</div>,
+}));
+
 function TestComponent() {
   return (
     <BrowserRouter>
@@ -31,10 +35,19 @@ describe('RunRequestTableTest', () => {
     render(<TestComponent />);
 
     runRequests.forEach((req) => {
-      req.tags.forEach(({key, value}) => {
-        expect(screen.getByText(`${key}: ${value}`)).toBeVisible();
-      });
       expect(screen.getByTestId(req.runKey!)).toBeVisible();
     });
   });
+
+  it('renders preview button and opens dialog on click', async () => {
+    render(<TestComponent />);
+
+    const previewButton = screen.getByTestId(`preview-${runRequests[0]!.runKey || ''}`);
+    expect(previewButton).toBeVisible();
+    previewButton.click();
+
+    await waitFor(() => {
+      expect(screen.getByText(/RunConfigDialog/i)).toBeVisible();
+    });
+  });
 });
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
index 34e6a802718a3..944295f2f90e0 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
@@ -84,4 +84,42 @@ describe('EvaluateScheduleTest', () => {
       expect(screen.getByText('Skipped')).toBeVisible();
     });
   });
+
+  it('allows you to test again', async () => {
+    render(<Test mocks={[GetScheduleQueryMock, ScheduleDryRunMutationSkipped]} />);
+    const selectButton = await screen.findByTestId('tick-selection');
+    await userEvent.click(selectButton);
+    await waitFor(() => {
+      expect(screen.getByTestId('tick-5')).toBeVisible();
+    });
+    await userEvent.click(screen.getByTestId('tick-5'));
+    await userEvent.click(screen.getByTestId('continue'));
+    await waitFor(() => {
+      expect(screen.getByText('Skipped')).toBeVisible();
+    });
+    await userEvent.click(screen.getByTestId('try-again'));
+    expect(screen.queryByText('Failed')).toBe(null);
+    expect(screen.queryByText('Skipped')).toBe(null);
+  });
+
+  it('launches all runs', async () => {
+    render(<Test mocks={[GetScheduleQueryMock, ScheduleDryRunMutationRunRequests]} />);
+    const selectButton = await screen.findByTestId('tick-selection');
+    await userEvent.click(selectButton);
+    await waitFor(() => {
+      expect(screen.getByTestId('tick-5')).toBeVisible();
+    });
+    await userEvent.click(screen.getByTestId('tick-5'));
+    await userEvent.click(screen.getByTestId('continue'));
+    await waitFor(() => {
+      expect(screen.getByText(/1\s+run request/i)).toBeVisible();
+      expect(screen.getByTestId('launch-all')).not.toBeDisabled();
+    });
+
+    userEvent.click(screen.getByTestId('launch-all'));
+
+    await waitFor(() => {
+      expect(screen.getByText(/Launching runs/i)).toBeVisible();
+    });
+  }, 10000);
 });
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
index 4e23fef7c256c..2051f5f6e3acb 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
@@ -57,6 +57,16 @@ describe('SensorDryRunTest', () => {
     });
   });
 
+  it('renders skip reason', async () => {
+    render(<Test mocks={[Mocks.SensorDryRunMutationSkipped]} />);
+    const cursorInput = await screen.findByTestId('cursor-input');
+    await userEvent.type(cursorInput, 'testing123');
+    await userEvent.click(screen.getByTestId('continue'));
+    await waitFor(() => {
+      expect(screen.getByText('Skipped')).toBeVisible();
+    });
+  });
+
   it('allows you to test again', async () => {
     render(<Test mocks={[Mocks.SensorDryRunMutationError]} />);
     const cursorInput = await screen.findByTestId('cursor-input');
@@ -72,13 +82,25 @@ describe('SensorDryRunTest', () => {
     expect(screen.getByTestId('cursor-input')).toBeVisible();
   });
 
-  it('renders skip reason', async () => {
-    render(<Test mocks={[Mocks.SensorDryRunMutationSkipped]} />);
+  it('launches all runs', async () => {
+    render(<Test mocks={[Mocks.SensorDryRunMutationRunRequests, Mocks.PersistCursorValueMock]} />);
     const cursorInput = await screen.findByTestId('cursor-input');
     await userEvent.type(cursorInput, 'testing123');
     await userEvent.click(screen.getByTestId('continue'));
     await waitFor(() => {
-      expect(screen.getByText('Skipped')).toBeVisible();
+      expect(screen.getByText(/3\srun requests/g)).toBeVisible();
+      expect(screen.queryByText('Skipped')).toBe(null);
+      expect(screen.queryByText('Failed')).toBe(null);
     });
-  });
+
+    await waitFor(() => {
+      expect(screen.getByTestId('launch-all')).not.toBeDisabled();
+    });
+
+    userEvent.click(screen.getByTestId('launch-all'));
+
+    await waitFor(() => {
+      expect(screen.getByText(/Launching runs/i)).toBeVisible();
+    });
+  }, 10000);
 });

From ea52c8b32909de5693b1188da03a434ed1c01780 Mon Sep 17 00:00:00 2001
From: David Liu <d.liu@dagsterlabs.com>
Date: Thu, 5 Dec 2024 14:14:28 -0500
Subject: [PATCH 2/4] add jest test for launch all

---
 .../EvaluateScheduleDialog.fixtures.tsx       |  91 +++++++++-
 .../SensorDryRunDialog.fixtures.tsx           | 161 ++++++++++++++++++
 .../__tests__/EvaluateScheduleDialog.test.tsx |  34 +++-
 .../__tests__/SensorDryRunDialog.test.tsx     |  33 +++-
 4 files changed, 314 insertions(+), 5 deletions(-)

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
index a747734e79869..c476ceb35c020 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
@@ -1,6 +1,7 @@
 import {MockedResponse} from '@apollo/client/testing';
 
 import {
+  RunStatus,
   buildDryRunInstigationTick,
   buildErrorChainLink,
   buildPipelineTag,
@@ -9,6 +10,8 @@ import {
   buildSchedule,
   buildTickEvaluation,
 } from '../../graphql/types';
+import {LAUNCH_MULTIPLE_RUNS_MUTATION} from '../../runs/RunUtils';
+import {LaunchMultipleRunsMutation} from '../../runs/types/RunUtils.types';
 import {GET_SCHEDULE_QUERY, SCHEDULE_DRY_RUN_MUTATION} from '../EvaluateScheduleDialog';
 import {GetScheduleQuery, ScheduleDryRunMutation} from '../types/EvaluateScheduleDialog.types';
 
@@ -63,7 +66,7 @@ export const scheduleDryWithWithRunRequest = {
               value: 'okay',
             }),
           ],
-          runKey: null,
+          runKey: 'EvaluateScheduleDialog.test.tsx:1675705668.993122345',
         }),
       ],
       skipReason: null,
@@ -164,3 +167,89 @@ export const ScheduleDryRunMutationSkipped: MockedResponse<ScheduleDryRunMutatio
     },
   },
 };
+
+export const ScheduleLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation> = {
+  request: {
+    query: LAUNCH_MULTIPLE_RUNS_MUTATION,
+    variables: {
+      executionParamsList: [
+        {
+          runConfigData: 'ops:\n  configurable_op:\n    config:\n      scheduled_date: 2023-01-29',
+          selector: {
+            jobName: 'saepe',
+            repositoryLocationName: 'testLocation',
+            repositoryName: 'testName',
+            assetSelection: [],
+            assetCheckSelection: [],
+            solidSelection: undefined,
+          },
+          mode: 'default',
+          executionMetadata: {
+            tags: [
+              {
+                key: 'dagster/schedule_name',
+                value: 'configurable_job_schedule',
+              },
+              {
+                key: 'date',
+                value: '2023-01-29',
+              },
+              {
+                key: 'github_test',
+                value: 'test',
+              },
+              {
+                key: 'okay_t2',
+                value: 'okay',
+              },
+            ],
+          },
+        },
+      ],
+    },
+  },
+  result: {
+    data: {
+      __typename: 'Mutation',
+      launchMultipleRuns: {
+        __typename: 'LaunchMultipleRunsResult',
+        launchMultipleRunsResult: [
+          {
+            __typename: 'LaunchRunSuccess',
+            run: {
+              __typename: 'Run',
+              id: '504b3a77-d6c4-440c-a128-7f59c9d75d59',
+              pipeline: {
+                __typename: 'PipelineSnapshot',
+                name: 'saepe',
+              },
+              tags: [
+                buildPipelineTag({
+                  key: 'dagster/schedule_name',
+                  value: 'configurable_job_schedule',
+                }),
+                buildPipelineTag({
+                  key: 'date',
+                  value: '2023-01-29',
+                }),
+                buildPipelineTag({
+                  key: 'github_test',
+                  value: 'test',
+                }),
+                buildPipelineTag({
+                  key: 'okay_t2',
+                  value: 'okay',
+                }),
+              ],
+              status: RunStatus.QUEUED,
+              runConfigYaml:
+                'ops:\n  configurable_op:\n    config:\n      scheduled_date: 2023-01-29',
+              mode: 'default',
+              resolvedOpSelection: null,
+            },
+          },
+        ],
+      },
+    },
+  },
+};
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
index 4959a6cc6dee3..e5c9dac3baf3b 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
@@ -3,6 +3,7 @@ import {MockedResponse} from '@apollo/client/testing';
 import {
   InstigationStatus,
   RunRequest,
+  RunStatus,
   buildDryRunInstigationTick,
   buildErrorChainLink,
   buildInstigationState,
@@ -13,6 +14,8 @@ import {
   buildSensorData,
   buildTickEvaluation,
 } from '../../graphql/types';
+import {LAUNCH_MULTIPLE_RUNS_MUTATION} from '../../runs/RunUtils';
+import {LaunchMultipleRunsMutation} from '../../runs/types/RunUtils.types';
 import {SET_CURSOR_MUTATION} from '../../sensors/EditCursorDialog';
 import {SetSensorCursorMutation} from '../../sensors/types/EditCursorDialog.types';
 import {EVALUATE_SENSOR_MUTATION} from '../SensorDryRunDialog';
@@ -177,3 +180,161 @@ export const PersistCursorValueMock: MockedResponse<SetSensorCursorMutation> = {
     },
   },
 };
+
+export const SensorLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation> = {
+  request: {
+    query: LAUNCH_MULTIPLE_RUNS_MUTATION,
+    variables: {
+      executionParamsList: [
+        {
+          runConfigData:
+            'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx',
+          selector: {
+            jobName: 'saepe',
+            repositoryLocationName: 'testLocation',
+            repositoryName: 'testName',
+            assetSelection: [],
+            assetCheckSelection: [],
+            solidSelection: undefined,
+          },
+          mode: 'default',
+          executionMetadata: {
+            tags: [
+              {
+                key: 'dagster2',
+                value: 'test',
+              },
+              {
+                key: 'marco2',
+                value: 'salazar2',
+              },
+            ],
+          },
+        },
+        {
+          runConfigData:
+            'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx',
+          selector: {
+            jobName: 'saepe',
+            repositoryLocationName: 'testLocation',
+            repositoryName: 'testName',
+            assetSelection: [],
+            assetCheckSelection: [],
+            solidSelection: undefined,
+          },
+          mode: 'default',
+          executionMetadata: {
+            tags: [
+              {
+                key: 'dagster3',
+                value: 'test',
+              },
+              {
+                key: 'marco3',
+                value: 'salazar3',
+              },
+            ],
+          },
+        },
+        {
+          runConfigData:
+            'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx',
+          selector: {
+            jobName: 'saepe',
+            repositoryLocationName: 'testLocation',
+            repositoryName: 'testName',
+            assetSelection: [],
+            assetCheckSelection: [],
+            solidSelection: undefined,
+          },
+          mode: 'default',
+          executionMetadata: {
+            tags: [
+              {
+                key: 'dagster6',
+                value: 'test',
+              },
+              {
+                key: 'marco6',
+                value: 'salazar6',
+              },
+            ],
+          },
+        },
+      ],
+    },
+  },
+  result: {
+    data: {
+      __typename: 'Mutation',
+      launchMultipleRuns: {
+        __typename: 'LaunchMultipleRunsResult',
+        launchMultipleRunsResult: [
+          {
+            __typename: 'LaunchRunSuccess',
+            run: {
+              __typename: 'Run',
+              id: '504b3a77-d6c4-440c-a128-7f59c9d75d59',
+              pipeline: {
+                __typename: 'PipelineSnapshot',
+                name: 'saepe',
+              },
+              tags: [
+                buildPipelineTag({key: 'dagster2', value: 'test'}),
+                buildPipelineTag({key: 'marco2', value: 'salazar2'}),
+              ],
+              status: RunStatus.QUEUED,
+              runConfigYaml:
+                'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx\n',
+              mode: 'default',
+              resolvedOpSelection: null,
+            },
+          },
+          {
+            __typename: 'LaunchRunSuccess',
+            run: {
+              __typename: 'Run',
+              id: '6745cd03-3d89-4fd2-a41f-6b9d9ffdc134',
+              pipeline: {
+                __typename: 'PipelineSnapshot',
+                name: 'saepe',
+              },
+              tags: [
+                buildPipelineTag({key: 'dagster3', value: 'test'}),
+                buildPipelineTag({key: 'marco3', value: 'salazar3'}),
+              ],
+
+              status: RunStatus.QUEUED,
+              runConfigYaml:
+                'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx\n',
+
+              mode: 'default',
+              resolvedOpSelection: null,
+            },
+          },
+          {
+            __typename: 'LaunchRunSuccess',
+            run: {
+              __typename: 'Run',
+              id: '7ed35f69-42cf-4518-84a4-c97d0551a56b',
+              pipeline: {
+                __typename: 'PipelineSnapshot',
+                name: 'simple_config_job',
+              },
+              tags: [
+                buildPipelineTag({key: 'dagster6', value: 'test'}),
+                buildPipelineTag({key: 'marco6', value: 'salazar6'}),
+              ],
+              status: RunStatus.QUEUED,
+              runConfigYaml:
+                'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx\n',
+
+              mode: 'default',
+              resolvedOpSelection: null,
+            },
+          },
+        ],
+      },
+    },
+  },
+};
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
index 944295f2f90e0..6c17208d0628d 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/EvaluateScheduleDialog.test.tsx
@@ -1,6 +1,7 @@
 import {MockedProvider, MockedResponse} from '@apollo/client/testing';
 import {render, screen, waitFor} from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
+import {MemoryRouter, useHistory} from 'react-router-dom';
 
 import {Resolvers} from '../../apollo-client';
 import {EvaluateScheduleDialog} from '../EvaluateScheduleDialog';
@@ -9,6 +10,7 @@ import {
   ScheduleDryRunMutationError,
   ScheduleDryRunMutationRunRequests,
   ScheduleDryRunMutationSkipped,
+  ScheduleLaunchAllMutation,
 } from '../__fixtures__/EvaluateScheduleDialog.fixtures';
 
 // This component is unit tested separately so mocking it out
@@ -18,6 +20,12 @@ jest.mock('../DryRunRequestTable', () => {
   };
 });
 
+// Mocking useHistory
+jest.mock('react-router-dom', () => ({
+  ...jest.requireActual('react-router-dom'),
+  useHistory: jest.fn(),
+}));
+
 const onCloseMock = jest.fn();
 
 function Test({mocks, resolvers}: {mocks?: MockedResponse[]; resolvers?: Resolvers}) {
@@ -103,7 +111,25 @@ describe('EvaluateScheduleTest', () => {
   });
 
   it('launches all runs', async () => {
-    render(<Test mocks={[GetScheduleQueryMock, ScheduleDryRunMutationRunRequests]} />);
+    const pushSpy = jest.fn();
+    const createHrefSpy = jest.fn();
+
+    (useHistory as jest.Mock).mockReturnValue({
+      push: pushSpy,
+      createHref: createHrefSpy,
+    });
+
+    render(
+      <MemoryRouter initialEntries={['/automation']}>
+        <Test
+          mocks={[
+            GetScheduleQueryMock,
+            ScheduleDryRunMutationRunRequests,
+            ScheduleLaunchAllMutation,
+          ]}
+        />
+      </MemoryRouter>,
+    );
     const selectButton = await screen.findByTestId('tick-selection');
     await userEvent.click(selectButton);
     await waitFor(() => {
@@ -121,5 +147,9 @@ describe('EvaluateScheduleTest', () => {
     await waitFor(() => {
       expect(screen.getByText(/Launching runs/i)).toBeVisible();
     });
-  }, 10000);
+
+    await waitFor(() => {
+      expect(pushSpy).toHaveBeenCalled();
+    });
+  });
 });
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
index 2051f5f6e3acb..c8307def66a00 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__tests__/SensorDryRunDialog.test.tsx
@@ -1,6 +1,7 @@
 import {MockedProvider, MockedResponse} from '@apollo/client/testing';
 import {render, screen, waitFor} from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
+import {MemoryRouter, useHistory} from 'react-router-dom';
 
 import {Resolvers} from '../../apollo-client';
 import {SensorDryRunDialog} from '../SensorDryRunDialog';
@@ -13,6 +14,12 @@ jest.mock('../DryRunRequestTable', () => {
   };
 });
 
+// Mocking useHistory
+jest.mock('react-router-dom', () => ({
+  ...jest.requireActual('react-router-dom'),
+  useHistory: jest.fn(),
+}));
+
 const onCloseMock = jest.fn();
 
 function Test({mocks, resolvers}: {mocks?: MockedResponse[]; resolvers?: Resolvers}) {
@@ -83,7 +90,25 @@ describe('SensorDryRunTest', () => {
   });
 
   it('launches all runs', async () => {
-    render(<Test mocks={[Mocks.SensorDryRunMutationRunRequests, Mocks.PersistCursorValueMock]} />);
+    const pushSpy = jest.fn();
+    const createHrefSpy = jest.fn();
+
+    (useHistory as jest.Mock).mockReturnValue({
+      push: pushSpy,
+      createHref: createHrefSpy,
+    });
+
+    render(
+      <MemoryRouter initialEntries={['/automation']}>
+        <Test
+          mocks={[
+            Mocks.SensorDryRunMutationRunRequests,
+            Mocks.PersistCursorValueMock,
+            Mocks.SensorLaunchAllMutation,
+          ]}
+        />
+      </MemoryRouter>,
+    );
     const cursorInput = await screen.findByTestId('cursor-input');
     await userEvent.type(cursorInput, 'testing123');
     await userEvent.click(screen.getByTestId('continue'));
@@ -102,5 +127,9 @@ describe('SensorDryRunTest', () => {
     await waitFor(() => {
       expect(screen.getByText(/Launching runs/i)).toBeVisible();
     });
-  }, 10000);
+
+    await waitFor(() => {
+      expect(pushSpy).toHaveBeenCalled();
+    });
+  });
 });

From 8202816c8e843b3f5c334bde9aeb839007e2c1aa Mon Sep 17 00:00:00 2001
From: David Liu <d.liu@dagsterlabs.com>
Date: Fri, 6 Dec 2024 23:15:11 -0500
Subject: [PATCH 3/4] use build functions

---
 .../EvaluateScheduleDialog.fixtures.tsx       | 24 ++++-----
 .../SensorDryRunDialog.fixtures.tsx           | 51 +++++++++----------
 2 files changed, 36 insertions(+), 39 deletions(-)

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
index c476ceb35c020..724b62da00125 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/EvaluateScheduleDialog.fixtures.tsx
@@ -4,8 +4,12 @@ import {
   RunStatus,
   buildDryRunInstigationTick,
   buildErrorChainLink,
+  buildLaunchMultipleRunsResult,
+  buildLaunchRunSuccess,
+  buildPipelineSnapshot,
   buildPipelineTag,
   buildPythonError,
+  buildRun,
   buildRunRequest,
   buildSchedule,
   buildTickEvaluation,
@@ -211,18 +215,14 @@ export const ScheduleLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutatio
   result: {
     data: {
       __typename: 'Mutation',
-      launchMultipleRuns: {
-        __typename: 'LaunchMultipleRunsResult',
+      launchMultipleRuns: buildLaunchMultipleRunsResult({
         launchMultipleRunsResult: [
-          {
-            __typename: 'LaunchRunSuccess',
-            run: {
-              __typename: 'Run',
+          buildLaunchRunSuccess({
+            run: buildRun({
               id: '504b3a77-d6c4-440c-a128-7f59c9d75d59',
-              pipeline: {
-                __typename: 'PipelineSnapshot',
+              pipeline: buildPipelineSnapshot({
                 name: 'saepe',
-              },
+              }),
               tags: [
                 buildPipelineTag({
                   key: 'dagster/schedule_name',
@@ -246,10 +246,10 @@ export const ScheduleLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutatio
                 'ops:\n  configurable_op:\n    config:\n      scheduled_date: 2023-01-29',
               mode: 'default',
               resolvedOpSelection: null,
-            },
-          },
+            }),
+          }),
         ],
-      },
+      }),
     },
   },
 };
diff --git a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
index e5c9dac3baf3b..98e691e5086a9 100644
--- a/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
+++ b/js_modules/dagster-ui/packages/ui-core/src/ticks/__fixtures__/SensorDryRunDialog.fixtures.tsx
@@ -7,8 +7,12 @@ import {
   buildDryRunInstigationTick,
   buildErrorChainLink,
   buildInstigationState,
+  buildLaunchMultipleRunsResult,
+  buildLaunchRunSuccess,
+  buildPipelineSnapshot,
   buildPipelineTag,
   buildPythonError,
+  buildRun,
   buildRunRequest,
   buildSensor,
   buildSensorData,
@@ -267,18 +271,16 @@ export const SensorLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation>
   result: {
     data: {
       __typename: 'Mutation',
-      launchMultipleRuns: {
-        __typename: 'LaunchMultipleRunsResult',
+      launchMultipleRuns: buildLaunchMultipleRunsResult({
         launchMultipleRunsResult: [
-          {
+          buildLaunchRunSuccess({
             __typename: 'LaunchRunSuccess',
-            run: {
+            run: buildRun({
               __typename: 'Run',
               id: '504b3a77-d6c4-440c-a128-7f59c9d75d59',
-              pipeline: {
-                __typename: 'PipelineSnapshot',
+              pipeline: buildPipelineSnapshot({
                 name: 'saepe',
-              },
+              }),
               tags: [
                 buildPipelineTag({key: 'dagster2', value: 'test'}),
                 buildPipelineTag({key: 'marco2', value: 'salazar2'}),
@@ -288,17 +290,16 @@ export const SensorLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation>
                 'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx\n',
               mode: 'default',
               resolvedOpSelection: null,
-            },
-          },
-          {
+            }),
+          }),
+          buildLaunchRunSuccess({
             __typename: 'LaunchRunSuccess',
-            run: {
+            run: buildRun({
               __typename: 'Run',
               id: '6745cd03-3d89-4fd2-a41f-6b9d9ffdc134',
-              pipeline: {
-                __typename: 'PipelineSnapshot',
+              pipeline: buildPipelineSnapshot({
                 name: 'saepe',
-              },
+              }),
               tags: [
                 buildPipelineTag({key: 'dagster3', value: 'test'}),
                 buildPipelineTag({key: 'marco3', value: 'salazar3'}),
@@ -307,20 +308,16 @@ export const SensorLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation>
               status: RunStatus.QUEUED,
               runConfigYaml:
                 'solids:\n  read_file:\n    config:\n      directory: /Users/marcosalazar/code/dagster/js_modules/dagster-ui/packages/ui-core/src/ticks/tests\n      filename: DryRunRequestTable.test.tsx\n',
-
               mode: 'default',
               resolvedOpSelection: null,
-            },
-          },
-          {
-            __typename: 'LaunchRunSuccess',
-            run: {
-              __typename: 'Run',
+            }),
+          }),
+          buildLaunchRunSuccess({
+            run: buildRun({
               id: '7ed35f69-42cf-4518-84a4-c97d0551a56b',
-              pipeline: {
-                __typename: 'PipelineSnapshot',
+              pipeline: buildPipelineSnapshot({
                 name: 'simple_config_job',
-              },
+              }),
               tags: [
                 buildPipelineTag({key: 'dagster6', value: 'test'}),
                 buildPipelineTag({key: 'marco6', value: 'salazar6'}),
@@ -331,10 +328,10 @@ export const SensorLaunchAllMutation: MockedResponse<LaunchMultipleRunsMutation>
 
               mode: 'default',
               resolvedOpSelection: null,
-            },
-          },
+            }),
+          }),
         ],
-      },
+      }),
     },
   },
 };

From 1759d79572491470052efaa5187461437b3e49c3 Mon Sep 17 00:00:00 2001
From: David Liu <d.liu@dagsterlabs.com>
Date: Sat, 7 Dec 2024 00:39:18 -0500
Subject: [PATCH 4/4] fix test

---
 .../dagster_graphql_tests/graphql/test_run_launcher.py    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
index 3a58623c301eb..e56f220535e71 100644
--- a/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
+++ b/python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
@@ -272,7 +272,7 @@ def test_launch_multiple_runs_success_and_failure(
         launchSuccessExecutionParams = [
             {
                 "selector": {
-                    "repositoryLocationName": "test",
+                    "repositoryLocationName": "test_location",
                     "repositoryName": "test_repo",
                     "pipelineName": "no_config_job",
                     "solidSelection": None,
@@ -283,7 +283,7 @@ def test_launch_multiple_runs_success_and_failure(
             },
             {
                 "selector": {
-                    "repositoryLocationName": "test",
+                    "repositoryLocationName": "test_location",
                     "repositoryName": "test_repo",
                     "pipelineName": "no_config_job",
                     "solidSelection": None,
@@ -297,7 +297,7 @@ def test_launch_multiple_runs_success_and_failure(
         pipelineNotFoundExecutionParams = [
             {
                 "selector": {
-                    "repositoryLocationName": "test",
+                    "repositoryLocationName": "test_location",
                     "repositoryName": "test_dict_repo",
                     "pipelineName": "no_config_job",
                     "solidSelection": None,
@@ -308,7 +308,7 @@ def test_launch_multiple_runs_success_and_failure(
             },
             {
                 "selector": {
-                    "repositoryLocationName": "test",
+                    "repositoryLocationName": "test_location",
                     "repositoryName": "test_dict_repo",
                     "pipelineName": "no_config_job",
                     "solidSelection": None,