Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeItem not exported #293

Open
taivo opened this issue Jan 19, 2023 · 3 comments
Open

ThemeItem not exported #293

taivo opened this issue Jan 19, 2023 · 3 comments

Comments

@taivo
Copy link

taivo commented Jan 19, 2023

The documentation at https://react.daisyui.com/?path=/story/utils-theme--default refers to the ThemeItem tag but it doesn't look like it's exported for external use.

taivo added a commit to taivo/react-daisyui that referenced this issue Jan 19, 2023
taivo added a commit to taivo/react-daisyui that referenced this issue Jan 19, 2023
@benjitrosch
Copy link
Collaborator

Hi @taivo,

The <ThemeItem> component was never intended to be exported; it only exists for the sake of the Storybook. After all, it's not a component found in the daisy-ui design system. What do you want to use it for?

@taivo
Copy link
Author

taivo commented Jan 19, 2023

Hi @benjitrosch ,
Thanks for maintaining this excellent package!

I mainly suggest exporting <ThemeItem> because that tag was used in the docs example https://react.daisyui.com/?path=/story/utils-theme--default . There is a potential for confusion here for new users of the theming feature.

If you don't want to export, perhaps an alternative is to update the docs.

That said, it seems to me this tag would be a useful building block for theme selection by end users.

@stacygrace
Copy link

I got the same impression as @taivo and was also trying to use the ThemeItem as part of a user-facing theme picker. It would be nice to have a built-in ThemePicker component that used the look in the storybook to show themes, or like the one on the DaisyUI site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants