Question about branches and PR

[liusida]

Hi guys,

I saw that @daniel-lewis-ab is working on the reversion and @atlasan is working on forwardcompatible. And I've sumitted a PR to the master. Is master the branch I should PR to? Did I do it right? Or, should I join @atlasan to fix things on forwardcompatible?

I need some suggestion. Thanks!

[liusida]

And what does the phrase forward compatible mean? Does it mean that it has the latest featuers and will be merged to master progressively?

[atlasan]

Hi @liusida, good to see you here ^ _ ^
I chose the name for the temporary branch I'm working on. Surely the intention is to be compatible and forward looking ^ _ ^
Please feel free to join, need some hands in testing, cleaning, and improving.

[liusida]

Hi @liusida, good to see you here ^ _ ^ I chose the name for the temporary branch I'm working on. Surely the intention is to be compatible and forward looking ^ _ ^ Please feel free to join, need some hands in testing, cleaning, and improving.

Sounds like a plan. Do you have any specific tasks that I can work on? I can try one of them first.

[liusida]

And, what do you think about the PR #19, since that PR can make litegraph.js runnable in plain html, and we won't need to start a http server for the development any more. Should I PR to your branch instead of the master?

[liusida]

I've just learned the basics of jest. And I think I can do some testing to start with. What's your opinion towards using ChatGPT to accelerate the writing of test cases?

[atlasan]

Sounds like a plan. Do you have any specific tasks that I can work on? I can try one of them first.

I would say:

• implementing PR fix the path for uglifyjs #19 seems good to me
• think about the best way to allow different version of the library in ComfyUI ( I was imagining a setting in there where to specify the name of the folder/file to be included. This would help testing and switching to pre-release or custom UIs easily. eg. clone the repo in a folder and specify that folder name in the ComfyUI settings
• test the library with built-in demos and with ComfyUI for potential issues (I will try to test with WebGlStudio too)
• review the changes made since branching to see what I have been working on and detect problems or clean up

And many more:

• review the implementation of CallbackHandlers and prototype simple extensions leveraging the system (like autoconnect or renamer) to debug and finish the implementation with many multiple callbacks
• check and think about ComfyUI LiteGraph extensions: some should be implemented in LG using CallbackHandlers
• check the list of implemented CallbackHandlers: update the docs, propose implementation of return value for many of those (when a callback would modify default behavior)
• create demo workflow and implement those in the default editor, we can make a demo per functionality and some complex testing
• rework and implement the node library provided in LG
• check and finish new logging system implementation ( console methods have been replaced, in the code some old debug need to be fixed or new debugs are to be added using good standards and with correct level )

[atlasan]

I've just learned the basics of jest. And I think I can do some testing to start with. What's your opinion towards using ChatGPT to accelerate the writing of test cases?

Nothing against as long as nice and working ^_ ^

What about making workflows that are tests themselves? The way to check at high level the system could be to use it for real.
A complex stepped demo would eventually cover two interests.

[liusida]

making workflows that are tests themselves

What a brilliant suggestion~ xD

[daniel-lewis-ab]

Any features you want to add are good on forwardcompatible, that's basically forked off of reversion AFAIK. My thought is that we're going to get reversion caught up, and then start porting over any features we want one at a time so that there's some discipline in how they're integrated while still allowing us to dev freely. Both Atlasan and I have trouble doing just one thing at a time so the commits and versioning are clean.

…

On Fri, Jun 7, 2024 at 1:14 AM Liu Sida ***@***.***> wrote: Hi guys, I saw that @daniel-lewis-ab <https://github.com/daniel-lewis-ab> is working on the reversion and @atlasan <https://github.com/atlasan> is working on forwardcompatible. And I've sumitted a PR to the master. Is master the branch I should PR to? Did I do it right? Or, should I join @atlasan <https://github.com/atlasan> to fix things on forwardcompatible? I need some suggestion. Thanks! — Reply to this email directly, view it on GitHub <#21>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC36LNYCAODAOFQKXVTY2QDZGFMUTAVCNFSM6AAAAABI6DHHZSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTSNZWGA3TEMA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[liusida]

think about the best way to allow different version of the library in ComfyUI ( I was imagining a setting in there where to specify the name of the folder/file to be included. This would help testing and switching to pre-release or custom UIs easily. eg. clone the repo in a folder and specify that folder name in the ComfyUI settings

Yeah. I naively thought that compiling this project into a litegraph.core.js file and replace the original one in ComfyUI would automatically bring new features to ComfyUI. (I've actually tried, but it doesn't work...)

How do you do this manually @atlasan ? Can the current forwardcompatible branch be applied to current ComfyUI?

I'll start a new issue on this #22.