From d07c2675612069d6640dd5606fdc076cc521d1a7 Mon Sep 17 00:00:00 2001 From: Daniel Gafni Date: Wed, 1 Nov 2023 21:15:44 +0100 Subject: [PATCH 1/3] :bug: fix matrix packages intallation in CI --- .github/workflows/ci.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 73a4ce8..733cb6a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,9 @@ jobs: virtualenvs-in-project: false installer-parallel: true - name: Install dependencies - run: poetry install --all-extras --sync && pip install --force-reinstall polars~=${{ matrix.polars_version }} dagster~=${{ matrix.dagster_version }} + run: poetry install --all-extras --sync + - name: Install matrix overrides + run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }} - name: Print polars info run: python -c 'import polars; print(polars.show_versions())' - name: Print dagster info @@ -93,7 +95,9 @@ jobs: virtualenvs-in-project: false installer-parallel: true - name: Install dependencies - run: poetry install --all-extras --sync && pip install --force-reinstall polars~=${{ matrix.polars_version }} dagster~=${{ matrix.dagster_version }} + run: poetry install --all-extras --sync + - name: Install matrix overrides + run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }} - name: Run pre-commit hooks run: pre-commit run --all-files From 52d20185f7ce9f3b4b7cda0838d579fa37f59f33 Mon Sep 17 00:00:00 2001 From: Daniel Gafni Date: Wed, 1 Nov 2023 21:17:00 +0100 Subject: [PATCH 2/3] return dagster 1.5.0 --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 733cb6a..86ab2d6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,7 +32,7 @@ jobs: - "3.8" dagster_version: - "1.4.0" - # - "1.5.0" disabled until https://github.com/dagster-io/dagster/issues/17436 is fixed + - "1.5.0" polars_version: - "0.17.0" - "0.18.0" @@ -76,7 +76,7 @@ jobs: - "3.8" dagster_version: - "1.4.0" - # - "1.5.0" disabled until https://github.com/dagster-io/dagster/issues/17436 is fixed + - "1.5.0" polars_version: - "0.17.0" - "0.18.0" From 66e9c1babf13dca70996db36732c8abd68036035 Mon Sep 17 00:00:00 2001 From: Daniel Gafni Date: Wed, 1 Nov 2023 22:10:05 +0100 Subject: [PATCH 3/3] make sure all extras are installed --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 86ab2d6..584a132 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,7 +53,7 @@ jobs: - name: Install dependencies run: poetry install --all-extras --sync - name: Install matrix overrides - run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }} + run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }}&& poetry install --sync --all-extras - name: Print polars info run: python -c 'import polars; print(polars.show_versions())' - name: Print dagster info @@ -97,7 +97,7 @@ jobs: - name: Install dependencies run: poetry install --all-extras --sync - name: Install matrix overrides - run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }} + run: poetry add polars=~${{ matrix.polars_version }} dagster=~${{ matrix.dagster_version }} && poetry install --sync --all-extras - name: Run pre-commit hooks run: pre-commit run --all-files