Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack info returned #35

Closed
general03 opened this issue Mar 5, 2019 · 3 comments
Closed

Lack info returned #35

general03 opened this issue Mar 5, 2019 · 3 comments

Comments

@general03
Copy link

Is your feature request related to a problem? Please describe.
I don't see the code where you extract current_version, size and updated in https://github.com/danieliu/play-scraper/blob/master/play_scraper/utils.py
Whereas in your README you explained that it's possible !

Describe the solution you'd like
I would like details method return this informations

Thanks

@danieliu
Copy link
Owner

danieliu commented Apr 3, 2019

The additional information section is parsed here. If these fields are being returned as None, it's likely because you're scraping in a different language as the mapping is hardcoded in english.

Please create a new issue if you're seeing unexpected behavior.

@danieliu danieliu closed this as completed Apr 3, 2019
@general03
Copy link
Author

Ok, I found the problem

    additional_info_data = parse_additional_info(
        soup.select_one('.xyOfqd'))

The class xyOfqd depend on language ? In the play store webpage I found IxB2fe class instead of xyOfqd

When I update this class name all works

@danieliu
Copy link
Owner

danieliu commented Apr 3, 2019

This has been fixed in d583ae8. Please update to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants