Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting similar apps returns empty list #49

Closed
woutwoot opened this issue May 13, 2019 · 1 comment
Closed

Getting similar apps returns empty list #49

woutwoot opened this issue May 13, 2019 · 1 comment
Labels

Comments

@woutwoot
Copy link

Describe the bug
Getting similar apps is broken, it does not return any apps. This also fails in the unit tests with AssertionError: 0 not greater than 0

To Reproduce
Easiest way is to run the unit tests.

Expected behavior
The tests do not fail and similar apps are returned when using the method.

Desktop (please complete the following information):

  • OS: macOS 10.14
  • Python Version 3.7
  • play_scraper Version 0.5.5
@woutwoot woutwoot added the bug label May 13, 2019
@NikolaiSachok
Copy link

NikolaiSachok commented Jun 21, 2019

Looks like Google changed or obfuscated css attributes names the plugin uses to get similar apps details from html response.

I created a pull request with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants