You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
play_scraper/constants.py - GL_COUNTRY_CODES list, any gl= must match, but this does not match Google's own country code list at https://developers.google.com/public-data/docs/canonical/countries_csv, which leads to 404 errors on countries listed in GL_COUNTRY_CODES and valid country codes being rejected.
To Reproduce
Run any play_scraper call with a gl="kp", valid according to play-scraper, not valid according to Google:
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://play.google.com/store/apps/developer?id=&gl=kp&hl=en
Run play_scraper with gl='im' results in error from play-scraper:
ValueError: im is not a valid geolocation country code.
Describe the bug
play_scraper/constants.py - GL_COUNTRY_CODES list, any gl= must match, but this does not match Google's own country code list at https://developers.google.com/public-data/docs/canonical/countries_csv, which leads to 404 errors on countries listed in GL_COUNTRY_CODES and valid country codes being rejected.
To Reproduce
Run any play_scraper call with a gl="kp", valid according to play-scraper, not valid according to Google:
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://play.google.com/store/apps/developer?id=&gl=kp&hl=en
Run play_scraper with gl='im' results in error from play-scraper:
ValueError: im is not a valid geolocation country code.
However https://play.google.com/store/apps/developer?id=&gl=im results in valid content from Google.
Expected behavior
More maintained GL_COUNTRY_CODE list, or allowing overrides to not validate internally.
The text was updated successfully, but these errors were encountered: