Adding a todo comment, tuzig#106

daonb · daonb · commit a56ead90ff5d · 2024-05-27T14:08:29.000+03:00
diff --git a/peers/pane.go b/peers/pane.go
@@ -97,6 +97,8 @@ func NewPane(peer *Peer, ws *pty.Winsize, parent int) (*Pane, error) {
 			return nil, fmt.Errorf(
 				"Got a pane request with an illegal parrent pane id: %d", parent)
 		}
+		//TODO: handle a crash here, when there's a parent pane but no process yet
+		//      https://github.com/tuzig/webexec/issues/106
 		parent = parentPane.C.Process.Pid
 	}
 	if ws != nil {

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,8 @@ func NewPane(peer Peer, ws pty.Winsize, parent int) (*Pane, error) {`
`97`	`97`	`return nil, fmt.Errorf(`
`98`	`98`	`"Got a pane request with an illegal parrent pane id: %d", parent)`
`99`	`99`	`}`
	`100`	`+ //TODO: handle a crash here, when there's a parent pane but no process yet`
	`101`	`+ // https://github.com/tuzig/webexec/issues/106`
`100`	`102`	`parent = parentPane.C.Process.Pid`
`101`	`103`	`}`
`102`	`104`	`if ws != nil {`