diff --git a/build_runner/CHANGELOG.md b/build_runner/CHANGELOG.md index 9f7b8c53d..d15fd5298 100644 --- a/build_runner/CHANGELOG.md +++ b/build_runner/CHANGELOG.md @@ -1,7 +1,6 @@ ## 2.5.1-wip -- Don't show stack traces if a generator throws `InvalidGenerationSourceError` - from `source_gen`. +- Don't log stack traces for subclasses of `Exception`. ## 2.5.0 diff --git a/build_runner_core/CHANGELOG.md b/build_runner_core/CHANGELOG.md index fca51d21d..407f7f83d 100644 --- a/build_runner_core/CHANGELOG.md +++ b/build_runner_core/CHANGELOG.md @@ -1,7 +1,6 @@ ## 9.0.1-wip -- Don't show stack traces if a generator throws `InvalidGenerationSourceError` - from `source_gen`. +- Don't log stack traces for subclasses of `Exception`. ## 9.0.0 diff --git a/build_runner_core/lib/src/logging/build_log.dart b/build_runner_core/lib/src/logging/build_log.dart index 677c261e7..9dafcebb7 100644 --- a/build_runner_core/lib/src/logging/build_log.dart +++ b/build_runner_core/lib/src/logging/build_log.dart @@ -5,8 +5,7 @@ import 'dart:async'; import 'dart:math'; -import 'package:build/build.dart' - show AssetId, SyntaxErrorInAssetException, UnresolvableAssetException; +import 'package:build/build.dart' show AssetId; // ignore: implementation_imports import 'package:build_runner/src/internal.dart'; import 'package:logging/logging.dart'; @@ -414,8 +413,7 @@ class BuildLog { /// Renders [message] with optional [error] and [stackTrace]. /// - /// Drops `build_runner` exceptions that can be caused by normal user input: - /// [SyntaxErrorInAssetException] and [UnresolvableAssetException]. + /// Skips rendering [stackTrace] if [error] is an [Exception]. String renderThrowable( Object? message, [ Object? error, @@ -427,11 +425,7 @@ class BuildLog { result += '$error'; } - if (stackTrace != null && - error is! SyntaxErrorInAssetException && - error is! UnresolvableAssetException && - // From `source_gen`, use the name to avoid a build dependency. - error.runtimeType.toString() != 'InvalidGenerationSource') { + if (stackTrace != null && error is! Exception) { result += '\n$stackTrace'; } return result;