Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: setdiff1d for jax.jit and dask NaN-shaped arrays #116

Open
crusaderky opened this issue Jan 21, 2025 · 0 comments · May be fixed by #124
Open

BUG: setdiff1d for jax.jit and dask NaN-shaped arrays #116

crusaderky opened this issue Jan 21, 2025 · 0 comments · May be fixed by #124
Labels
lazy arrays
Milestone
0.6.1

Comments

@crusaderky
Copy link
Contributor

crusaderky commented Jan 21, 2025 •
edited
Loading

Follow-up to #115

  • setdiff1d fails when executed inside jax.jit. This is because of a call to xp.unique* without an explicit size= parameter.
  • By reading the code I'm fairly sure that the function fails if x1 and/or x2 have Dask backend and NaN in their shapes. Lacks a unit test.
@lucascolley lucascolley added the bug Something isn't working label Jan 21, 2025
@lucascolley lucascolley added this to the 0.6.1 milestone Jan 21, 2025
This was referenced Jan 22, 2025
Open
Draft
@lucascolley lucascolley removed the bug Something isn't working label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lazy arrays
Projects
None yet
Milestone
0.6.1
Development

Successfully merging a pull request may close this issue.

WIP ENH: setdiff1d for Dask and jax.jit crusaderky/array-api-extra
2 participants
@crusaderky @lucascolley