Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-react-app cannot be run with newer versions of eslint #385

Open
fgregg opened this issue Oct 9, 2024 · 4 comments
Open

eslint-config-react-app cannot be run with newer versions of eslint #385

fgregg opened this issue Oct 9, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@fgregg
Copy link
Member

fgregg commented Oct 9, 2024

Running docker build on a fresh new-django-app template fails with:

8.556 npm error code ERESOLVE
8.558 npm error ERESOLVE unable to resolve dependency tree
8.558 npm error
8.558 npm error While resolving: [email protected]
8.558 npm error Found: [email protected]
8.558 npm error node_modules/eslint
8.558 npm error   dev eslint@"^9.12.0" from the root project
8.558 npm error
8.558 npm error Could not resolve dependency:
8.558 npm error peer eslint@"^8.0.0" from [email protected]
8.558 npm error node_modules/eslint-config-react-app
8.558 npm error   dev eslint-config-react-app@"^7.0.1" from the root project
8.558 npm error
8.558 npm error Fix the upstream dependency conflict, or retry
8.558 npm error this command with --force or --legacy-peer-deps
8.558 npm error to accept an incorrect (and potentially broken) dependency resolution.

it looks like eslint-config-react-app has not been updated for two years.

eslint-plugin-react is already installed, so i'm not surew what else eslint-config-react-app is doing for us.

@fgregg fgregg added the bug Something isn't working label Oct 9, 2024
@fgregg
Copy link
Member Author

fgregg commented Oct 9, 2024

"eslint-plugin-flowtype": "^8.0.3",

also conflicts with newer version of eslint

as does

"eslint-plugin-react-hooks": "^4.6.2",

@hancush
Copy link
Member

hancush commented Oct 9, 2024

An unfortunate side effect of two different cookiecutters. We've already made this move in the Wagtail cookiecutter: https://github.com/datamade/how-to/blob/main/docker/templates/new-wagtail-app/%7B%7B%20cookiecutter.app_name%20%7D%7D/package.json

@hancush
Copy link
Member

hancush commented Oct 9, 2024

Actually, NVM.

@hancush
Copy link
Member

hancush commented Oct 9, 2024

Safe to remove config-create-react-app, IMO. I would suggest running npm-check-updates to upgrade and hopefully resolve dependency conflicts: https://www.npmjs.com/package/npm-check-updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants