Skip to content

Commit abd5ff0

Browse files
committed
chore: add @sandvige code review
1 parent f6349d2 commit abd5ff0

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ WORKDIR /tmp/cassandra-php-driver
33

44
RUN apt update -y \
55
&& apt install python3 pip cmake unzip mlocate build-essential git libuv1-dev libssl-dev libgmp-dev openssl zlib1g-dev libpcre3-dev openjdk-11-jre openjdk-11-jdk -y \
6-
&& pip install git+git://github.com/riptano/ccm.git@master
6+
&& pip install git+https://github.com/riptano/ccm.git@master
77

88
COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin
99
RUN docker-php-source extract \

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ This driver works exclusively with the Cassandra Query Language v3 (CQL3) and
4343
Cassandra's native protocol. The current version works with:
4444

4545
* Apache Cassandra versions 2.1, 2.2 and 3.0+
46-
* PHP 5.6, PHP 7.0, and PHP 7.1
46+
* PHP 5.6, PHP 7.0, PHP 7.1 and PHP 8.1
4747
* 32-bit (x86) and 64-bit (x64)
4848
* Thread safe (TS) and non-thread safe (NTS)
4949
* Compilers: GCC 4.1.2+, Clang 3.4+, and MSVC 2010/2012/2013/2015

tests/integration/Cassandra/DatatypeIntegrationTests.php

+2
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,8 @@ protected function verifyValue($tableName, $type, $key, $value) {
202202
if (isset($row['value'])) {
203203
if ($value instanceof \Countable) {
204204
$this->assertEquals(count($row['value']), count($value));
205+
} else {
206+
$this->assertEquals($row['value'], $value);
205207
}
206208
if (is_object($row['value'])) {
207209
$this->assertEquals($row['value']->type(), $type);

0 commit comments

Comments
 (0)