Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show opening hours in a different format #31

Open
watson opened this issue Jan 12, 2016 · 11 comments
Open

Show opening hours in a different format #31

watson opened this issue Jan 12, 2016 · 11 comments

Comments

@watson
Copy link
Contributor

watson commented Jan 12, 2016

Opening hours was recently added to the entries, but as the last column on the table. Some places have the same opening hours each week which makes it easy to add to a table, but some (like the one just added in #30) have 6 different times per week.

I'd suggest either making linebreaks for each diffrent time or moving it outside the table.

What do you guys think?

@daviddias
Copy link
Owner

I agree to this 👍 I had commented on the PR that we might/should take that direction it if starts looking messy

@daviddias
Copy link
Owner

Having a separate time table and a link to an always updated timetable (because they change through the year), for example to the place website, google place page, foursquare, zomato, etc, would be the better solution, otherwise we might create falsy expectations

@watson
Copy link
Contributor Author

watson commented Jan 12, 2016

@diasdavid Yeah, I'm pretty worried that it's tough to keep up to date. On the other hand, some places don't advertise anything them selfs, so it's nice to have in those cases.

@watson
Copy link
Contributor Author

watson commented Jan 12, 2016

I think we should also agree on a format. I suggest:

  1. 3 letter abbreviations for days with first letter uppercase (e.g. Mon instead of Monday)
  2. 24 hour clock (i.e. no am or pm)
  3. Colons between hours and minutes (e.g. 13:00 instead of 13.00)
  4. Weekday ranges shown with a hyphen without spaces around (e.g. Mon-Sat instead of Mon - Sat)
  5. Hour ranges shown with a hyphen without spaces around (e.g. 9:30-18:00 instead of 9:00 - 18:00)

@daviddias
Copy link
Owner

agreed, and I would prefer a 2xRow 7xColumn layer, to avoid making the scrolling incredibly large, what about:

Sun | Mon | Tue | Wed | Thu | Fri | Sat
:--: | :--: | :--: | :--: | :--: | :--: | :--: | 
9:00-14:00 | 9:00-18:00 | 9:00-19:00 | 9:00-20:00 | 10:00-13:00 | 9:00-16:00 | 9:00-14:00 | 

EDIT: saw your edit after I've refreshed, continue agree with everything, on 4) I believe we can gain a bit of having a column for each day, because it will make it easier if someone wants to parse this data

@daviddias
Copy link
Owner

@watson thoughts on latest proposal? Shall we proceed? :)

@watson
Copy link
Contributor Author

watson commented Jan 14, 2016

Being non-american I'd personally like Monday to be the first day of the week 😉 - ISO 8601 agrees, but I'm open to suggestions.

Testing different formats:

Mon Tue Wed Thu-Fri Sat Sun
9:00-14:00 9:00-18:00 9:00-19:00 9:00-20:00 10:00-13:00 closed
Mon 9:00-19:00
Tue 9:00-20:00
Wed 10:00-13:00
Thu 9:00-16:00
Fri-Sat 9:00-14:00
Sun closed
  • Mon: 9:00-19:00
  • Tue: 9:00-20:00
  • Wed: 10:00-13:00
  • Thu: 9:00-16:00
  • Fri-Sat: 9:00-14:00
  • Sun: closed
Mon:      9:00-19:00
Tue:      9:00-20:00
Wed:     10:00-13:00
Thu:      9:00-16:00
Fri-Sat:  9:00-14:00
Sun:          closed

Mon: 9:00-19:00, Tue: 9:00-20:00, Wed: 10:00-13:00, Thu: 9:00-16:00, Fri-Sat: 9:00-14:00, Sun: closed

@daviddias
Copy link
Owner

I like the one inside '`', takes less space.

Let's go with ISO 8601

@watson
Copy link
Contributor Author

watson commented Jan 14, 2016

@diasdavid the code comment version you mean?

@daviddias
Copy link
Owner

yes :)

@watson
Copy link
Contributor Author

watson commented Jan 14, 2016

@diasdavid It's a tiny bit taller though than the horizontal table, only if a lot of they days have different opening hours. I think most of the opening hours will only be 2-3 lines in which case the code comment is gonna be smallest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants