Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change orderer address #65

Merged
merged 8 commits into from
Nov 30, 2021
Merged

change orderer address #65

merged 8 commits into from
Nov 30, 2021

Conversation

sapthasurendran
Copy link
Collaborator

@sapthasurendran sapthasurendran commented Nov 12, 2021

contributes #68

Signed-off-by: sapthasurendran [email protected]

@@ -11,7 +11,7 @@ CC_NAME=${2}
CC_VERSION=${3:-"1.0"}
CC_SEQUENCE=${4:-"1"}
CC_INIT_FCN=${5:-"NA"}
CC_END_POLICY="OR(AND('Org1MSP.member','Org2MSP.member'),AND('Org1MSP.member','Org3MSP.member'),AND('Org3MSP.member','Org2MSP.member'))"
CC_END_POLICY="AND('Org1MSP.member','Org2MSP.member','Org3MSP.member')"
Copy link
Owner

@davidkel davidkel Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed this file so now we can specify the policy on the CLI, so this change is not needed now


elif [ $USING_ORG -eq 3 ]; then
export CORE_PEER_LOCALMSPID="OrdererMSP"
export CORE_PEER_TLS_ROOTCERT_FILE=$PEER1_ORG3_CA
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be ORDERER3_CA ?

export CORE_PEER_LOCALMSPID="OrdererMSP"
export CORE_PEER_TLS_ROOTCERT_FILE=$PEER1_ORG3_CA
export CORE_PEER_MSPCONFIGPATH=${PWD}/organizations/ordererOrganizations/example.com/users/[email protected]/msp
else
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add 4 and 5 as we have added the others now

Copy link
Owner

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some detail about how to use this in the main readme as well

@davidkel davidkel linked an issue Nov 29, 2021 that may be closed by this pull request
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Signed-off-by: sapthasurendran <[email protected]>
Copy link
Owner

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 9c8290f into davidkel:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test changing an address of a node
2 participants