From c460bb69eb98dcdf8463fc18f116efabd1f8d241 Mon Sep 17 00:00:00 2001 From: Salvador Aceves Date: Wed, 18 Jul 2018 19:39:53 -0500 Subject: [PATCH 1/3] avatarURL does not exists --- manuals/step-1-basic-graphql.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manuals/step-1-basic-graphql.md b/manuals/step-1-basic-graphql.md index f330e2a..21c9dd5 100644 --- a/manuals/step-1-basic-graphql.md +++ b/manuals/step-1-basic-graphql.md @@ -18,7 +18,7 @@ Queries - Go into github’s graphiql and run some queries - https://developer.g node { login name - avatarURL(size: 100) + avatarUrl(size: 100) } } } From ce23605432cb61bb4f07e0b16b07fd4ea2db1738 Mon Sep 17 00:00:00 2001 From: Salvador Aceves Date: Wed, 18 Jul 2018 20:02:03 -0500 Subject: [PATCH 2/3] fragment definition should also be included in query --- manuals/step-1-basic-graphql.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/manuals/step-1-basic-graphql.md b/manuals/step-1-basic-graphql.md index 21c9dd5..0e53c75 100644 --- a/manuals/step-1-basic-graphql.md +++ b/manuals/step-1-basic-graphql.md @@ -140,4 +140,10 @@ Cool we've succesfully queried and mutated data on a GraphQL API server. Let's t ...userFields } } + + fragment userFields on User { + name + bio + } + ``` From a45695a0c53fcd0bf8ef5eb308329740b9b1775e Mon Sep 17 00:00:00 2001 From: Salvador Aceves Date: Wed, 18 Jul 2018 20:03:22 -0500 Subject: [PATCH 3/3] it would be nice to make it work with one's own credentials wouldn't it ? --- server/index.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/index.js b/server/index.js index 5381527..9cc61de 100644 --- a/server/index.js +++ b/server/index.js @@ -6,8 +6,7 @@ const { graphqlExpress, graphiqlExpress } = require('graphql-server-express'); const { Schema } = require('./schema'); const { GithubConnector } = require('./github-connector'); -const GITHUB_LOGIN = 'davidyaha'; -const GITHUB_ACCESS_TOKEN = 'sjkafdhjkh32098097halskdjhf'; +const { GITHUB_LOGIN = 'davidyaha', GITHUB_ACCESS_TOKEN = 'sjkafdhjkh32098097halskdjhf' } = process.env; const app = express();